From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15D50C3F2C6 for ; Tue, 3 Mar 2020 19:16:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E2AF4208C3 for ; Tue, 3 Mar 2020 19:16:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583262994; bh=rRMdJDhihpbw492Akq7IhrH8YLKWl8VjOzCCbOZqZac=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=cRSATai5f1egEXQmCuk2mFrw7LTQQM2Sr+TRO72F2NU54Ot9SuXvE45l8CuzOkexX RPflQt9dWwlDv/heHI0L7N0cWmKMEiVdNTjvo4zDGQ7Sg/RguwMLVYL1CufjOzcmMG WAwwvDob2NZwV54+mLIo+Ss0IS035XtvhDIx7aks= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730704AbgCCTQc (ORCPT ); Tue, 3 Mar 2020 14:16:32 -0500 Received: from mail.kernel.org ([198.145.29.99]:48228 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729687AbgCCTQc (ORCPT ); Tue, 3 Mar 2020 14:16:32 -0500 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 141212073B; Tue, 3 Mar 2020 19:16:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583262991; bh=rRMdJDhihpbw492Akq7IhrH8YLKWl8VjOzCCbOZqZac=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DsP98JqYh3FZtjF1CgaIUF1AvB9sYez3Kr5jeTN/D4eI6y+Y2osl0oCTFHFAcXdE3 E2uj9eZLuK/81D2DscuklPOQ5jC12DWI+V9I2qOViOeoGxqyFsUDmSREGzym4rN9s8 CieEbNz093Xkw5rG5vlq33olUAgybJvqxCT02uRI= Date: Tue, 3 Mar 2020 19:16:25 +0000 From: Will Deacon To: Joerg Roedel Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mediatek@lists.infradead.org, virtualization@lists.linux-foundation.org, Lorenzo Pieralisi , Hanjun Guo , Sudeep Holla , Rob Clark , Sean Paul , Robin Murphy , Matthias Brugger , Thierry Reding , Jean-Philippe Brucker , Andy Gross , Bjorn Andersson Subject: Re: [PATCH 00/14] iommu: Move iommu_fwspec out of 'struct device' Message-ID: <20200303191624.GC27329@willie-the-truck> References: <20200228150820.15340-1-joro@8bytes.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200228150820.15340-1-joro@8bytes.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Joerg, On Fri, Feb 28, 2020 at 04:08:06PM +0100, Joerg Roedel wrote: > here is a patch-set to rename iommu_param to dev_iommu and > establish it as a struct for generic per-device iommu-data. > Also move the iommu_fwspec pointer from struct device into > dev_iommu to have less iommu-related pointers in struct > device. > > The bigger part of this patch-set moves the iommu_priv > pointer from struct iommu_fwspec to dev_iommu, making is > usable for iommu-drivers which do not use fwspecs. > > The changes for that were mostly straightforward, except for > the arm-smmu (_not_ arm-smmu-v3) and the qcom iommu driver. > Unfortunatly I don't have the hardware for those, so any > testing of these drivers is greatly appreciated. I haven't had a chance to review this properly yet, but I did take it for a spin on my Seattle board with MMU-400 (arm-smmu) and it seems to work the same as before, so: Tested-by: Will Deacon # arm-smmu I'll try to review the patches soon. Cheers, Will