Re: [PATCH V5 3/4] mailbox: imx: add SCU MU support

[kbuild test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3405 bytes --]

Hi,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on 770fbb32d34e5d6298cc2be590c9d2fd6069aa17]

url:    https://github.com/0day-ci/linux/commits/peng-fan-nxp-com/mailbox-firmware-imx-support-SCU-channel-type/20200303-201748
base:    770fbb32d34e5d6298cc2be590c9d2fd6069aa17
config: m68k-allmodconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 7.5.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.5.0 make.cross ARCH=m68k 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   In file included from include/linux/device.h:15:0,
                    from include/linux/firmware/imx/ipc.h:11,
                    from drivers//mailbox/imx-mailbox.c:7:
   drivers//mailbox/imx-mailbox.c: In function 'imx_mu_scu_tx':
>> drivers//mailbox/imx-mailbox.c:160:23: warning: format '%li' expects argument of type 'long int', but argument 3 has type 'unsigned int' [-Wformat=]
       dev_err(priv->dev, "Exceed max msg size (%li) on TX, got: %i\n", sizeof(*msg), msg->hdr.size);
                          ^
   include/linux/dev_printk.h:19:22: note: in definition of macro 'dev_fmt'
    #define dev_fmt(fmt) fmt
                         ^~~
>> drivers//mailbox/imx-mailbox.c:160:4: note: in expansion of macro 'dev_err'
       dev_err(priv->dev, "Exceed max msg size (%li) on TX, got: %i\n", sizeof(*msg), msg->hdr.size);
       ^~~~~~~
   drivers//mailbox/imx-mailbox.c: In function 'imx_mu_scu_rx':
   drivers//mailbox/imx-mailbox.c:188:22: warning: format '%li' expects argument of type 'long int', but argument 3 has type 'unsigned int' [-Wformat=]
      dev_err(priv->dev, "Exceed max msg size (%li) on RX, got: %i\n",
                         ^
   include/linux/dev_printk.h:19:22: note: in definition of macro 'dev_fmt'
    #define dev_fmt(fmt) fmt
                         ^~~
   drivers//mailbox/imx-mailbox.c:188:3: note: in expansion of macro 'dev_err'
      dev_err(priv->dev, "Exceed max msg size (%li) on RX, got: %i\n",
      ^~~~~~~

vim +/dev_err +160 drivers//mailbox/imx-mailbox.c

   144	
   145	static int imx_mu_scu_tx(struct imx_mu_priv *priv,
   146				 struct imx_mu_con_priv *cp,
   147				 void *data)
   148	{
   149		struct imx_sc_rpc_msg_max *msg = data;
   150		u32 *arg = data;
   151		int i;
   152	
   153		switch (cp->type) {
   154		case IMX_MU_TYPE_TX:
   155			if (msg->hdr.size > sizeof(*msg)) {
   156				/*
   157				 * The real message size can be different to
   158				 * struct imx_sc_rpc_msg_max size
   159				 */
 > 160				dev_err(priv->dev, "Exceed max msg size (%li) on TX, got: %i\n", sizeof(*msg), msg->hdr.size);
   161				return -EINVAL;
   162			}
   163	
   164			for (i = 0; i < msg->hdr.size; i++)
   165				imx_mu_write(priv, *arg++, priv->dcfg->xTR[i % 4]);
   166	
   167			imx_mu_xcr_rmw(priv, IMX_MU_xCR_TIEn(cp->idx), 0);
   168			break;
   169		default:
   170			dev_warn_ratelimited(priv->dev, "Send data on wrong channel type: %d\n", cp->type);
   171			return -EINVAL;
   172		}
   173	
   174		return 0;
   175	}
   176	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 53127 bytes --]