From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64DD2C3F2D1 for ; Wed, 4 Mar 2020 12:32:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 344C720838 for ; Wed, 4 Mar 2020 12:32:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583325142; bh=lxrZgNmeuYm0I4UesWaAuWnWvddGAXfMa7PxZjfUkeU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=wYB3rl3gchpc+8eKWE8LoNYZmhlbG8wYuNkWM3aHHBmgfJfjgZ5qYGz3yQ1xzlcvF mu9NxA+vW9Y+lnZkBYeRGOiq6G1eTWg05U9Pvni0A3KVI4ymQkcZTM5a0EWOlos/+U K/Nkc0tCraDo028c7t+cRnNvEY/2sseLe/jZRlAY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388037AbgCDMcV (ORCPT ); Wed, 4 Mar 2020 07:32:21 -0500 Received: from mail-wr1-f66.google.com ([209.85.221.66]:45837 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728953AbgCDMcV (ORCPT ); Wed, 4 Mar 2020 07:32:21 -0500 Received: by mail-wr1-f66.google.com with SMTP id v2so2152593wrp.12; Wed, 04 Mar 2020 04:32:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=oOoIMe4ipuObrP+M1ytu6BXg4FmUGi1YFKtc9FzmxHk=; b=k1jBNafNagIx53DiNwjOOrymH4k7l5lJ9DKD5UabdltRBPsblcBwxncK/G8TINIXpL AjmglINw36fmuwY/ePNT3pp/T91HEUGxIZpaDtUs1MKMiF7vK+nP/76bXoHzb4jFl6w5 XCzGcPqVsNASaUfSiuj41GYuMw6dpmgLHcc0QkpmRZjR0VYw0gm2D5AhsXcnfv4VcI9Y RTyNrD9XIXU5TAsDkXpHQYBFTAOPKWZ2LgwIe98ZOtFL+0ObZm2CQCTA91vSaemRoLfi fxzF2EL8DAp4dgUOXeFleF//zkGqn1QERDSpAgvZBvtiCkqiucoJR9zFv/6+lWRluEe3 /1hQ== X-Gm-Message-State: ANhLgQ1oEJWKdVxEIb6UXc1+rZQoJ6n0zVjq5xDCaxmyCIhMRCM8jAmG EiCJO40GlAtAsdlP7sVmx3I= X-Google-Smtp-Source: ADFU+vu2v6UTlvfB5gN7rglYo5YNbLmHFipxXKL6wWNpjacyXl05jHGXC9Tow/qo/wLCBkMUNsWsHQ== X-Received: by 2002:a5d:6141:: with SMTP id y1mr3739043wrt.146.1583325138786; Wed, 04 Mar 2020 04:32:18 -0800 (PST) Received: from localhost (prg-ext-pat.suse.com. [213.151.95.130]) by smtp.gmail.com with ESMTPSA id i204sm4029964wma.44.2020.03.04.04.32.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Mar 2020 04:32:17 -0800 (PST) Date: Wed, 4 Mar 2020 13:32:17 +0100 From: Michal Hocko To: Shakeel Butt Cc: Roman Gushchin , Johannes Weiner , Andrew Morton , Linux MM , Cgroups , LKML Subject: Re: [PATCH v2] memcg: css_tryget_online cleanups Message-ID: <20200304123217.GK16139@dhcp22.suse.cz> References: <20200302203109.179417-1-shakeelb@google.com> <20200303093251.GD4380@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 03-03-20 15:49:41, Shakeel Butt wrote: > On Tue, Mar 3, 2020 at 1:32 AM Michal Hocko wrote: [...] > > Could you be more specific about the swap in case please? > > > > With swap accounting enabled, if the memcg of the swapped out page is > not online then the memcg extracted from the given 'mm' will be > charged and if 'mm' is NULL then root memcg will be charged. However I > could not find a code path where the given 'mm' will be NULL for > swap-in case. Yes, this is my understanding as well. All the paths are getting mm from a vma AFAICS. This is a valuable information for the changelog. -- Michal Hocko SUSE Labs