From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CBBFC3F2CD for ; Wed, 4 Mar 2020 15:13:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E324821741 for ; Wed, 4 Mar 2020 15:13:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729617AbgCDPNT (ORCPT ); Wed, 4 Mar 2020 10:13:19 -0500 Received: from jabberwock.ucw.cz ([46.255.230.98]:57444 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728278AbgCDPNS (ORCPT ); Wed, 4 Mar 2020 10:13:18 -0500 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 143A51C031D; Wed, 4 Mar 2020 16:13:17 +0100 (CET) Date: Wed, 4 Mar 2020 16:13:16 +0100 From: Pavel Machek To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Stephen Boyd , Sai Prakash Ranjan , Rob Clark , Sean Paul , Douglas Anderson , Sasha Levin Subject: Re: [PATCH 4.19 04/87] drm/msm: Set dma maximum segment size for mdss Message-ID: <20200304151316.GA2367@duo.ucw.cz> References: <20200303174349.075101355@linuxfoundation.org> <20200303174349.401386271@linuxfoundation.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="pWyiEgJYm5f9v55/" Content-Disposition: inline In-Reply-To: <20200303174349.401386271@linuxfoundation.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --pWyiEgJYm5f9v55/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > Turning on CONFIG_DMA_API_DEBUG_SG results in the following error: >=20 > [ 12.078665] msm ae00000.mdss: DMA-API: mapping sg segment longer than = device claims to support [len=3D3526656] [max=3D65536] > [ 12.089870] WARNING: CPU: 6 PID: 334 at > /mnt/host/source/src/third_party/kernel/v4.19/kernel/dma/debug.c:1301 > debug_dma_map_sg+0x1dc/0x318 This one leaks resources in the (very improbable) case of error; it needs to goto cleanup instead of simply returning. > +++ b/drivers/gpu/drm/msm/msm_drv.c > @@ -492,6 +492,14 @@ static int msm_drm_init(struct device *dev, struct d= rm_driver *drv) > if (ret) > goto err_msm_uninit; > =20 > + if (!dev->dma_parms) { > + dev->dma_parms =3D devm_kzalloc(dev, sizeof(*dev->dma_parms), > + GFP_KERNEL); > + if (!dev->dma_parms) > + return -ENOMEM; > + } > + dma_set_max_seg_size(dev, DMA_BIT_MASK(32)); > + > msm_gem_shrinker_init(ddev); > =20 Best regards, Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --pWyiEgJYm5f9v55/ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCXl/FjAAKCRAw5/Bqldv6 8rTIAJ4/hePVrpzv/17tNe4THoUwLxsNIQCgmmOuDfrbfxZjctYeTlR8ZcTce2s= =f9d2 -----END PGP SIGNATURE----- --pWyiEgJYm5f9v55/--