From: Arvind Sankar <nivedita@alum.mit.edu>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: Arvind Sankar <nivedita@alum.mit.edu>,
Dave Hansen <dave.hansen@linux.intel.com>,
Andy Lutomirski <luto@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>,
the arch/x86 maintainers <x86@kernel.org>,
linux-efi <linux-efi@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/4] x86/mm/pat: Handle no-GBPAGES case correctly in populate_pud
Date: Wed, 4 Mar 2020 14:54:47 -0500 [thread overview]
Message-ID: <20200304195447.GA295419@rani.riverdale.lan> (raw)
In-Reply-To: <CAKv+Gu84Bj4tBz=+FhG6cqpYUjc5czaqiNAVDdKgqGoXbnHKbQ@mail.gmail.com>
On Wed, Mar 04, 2020 at 08:22:36PM +0100, Ard Biesheuvel wrote:
> The wrong one, obviously :-)
>
> With Haswell, I get [before]
>
> [ 0.368541] 0x0000000000900000-0x0000000000a00000 1M
> RW NX pte
> [ 0.369118] 0x0000000000a00000-0x0000000080000000 2038M
> RW PSE NX pmd
> [ 0.369592] 0x0000000080000000-0x00000000b9800000 920M
> pmd
> [ 0.370177] 0x00000000b9800000-0x00000000b9856000 344K
> pte
^^ so this is showing the region that didn't get mapped, so you did
reproduce the issue.
> [ 0.370649] 0x00000000b9856000-0x00000000b9a00000 1704K
> RW NX pte
> [ 0.371066] 0x00000000b9a00000-0x00000000baa00000 16M
> ro PSE x pmd
>
> and after
>
> [ 0.349577] 0x0000000000a00000-0x0000000080000000 2038M
> RW PSE NX pmd
> [ 0.350049] 0x0000000080000000-0x00000000b9800000 920M
> pmd
> [ 0.350514] 0x00000000b9800000-0x00000000b9856000 344K
> pte
^^ but it didn't get fixed :( This region should now be mapped properly
with flags RW/NX.
> [ 0.351013] 0x00000000b9856000-0x00000000b9a00000 1704K
> RW NX pte
>
> so i'm still doing something wrong, I think?
You're *sure* the after is actually after? There seems to be no change
at all, the patch should have had some effect.
next prev parent reply other threads:[~2020-03-04 19:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-03 20:54 [PATCH 0/4] Bugfix + small cleanup to populate_p[mug]d Arvind Sankar
2020-03-03 20:54 ` [PATCH 1/4] x86/mm/pat: Handle no-GBPAGES case correctly in populate_pud Arvind Sankar
2020-03-04 8:17 ` Ard Biesheuvel
2020-03-04 15:49 ` Arvind Sankar
2020-03-04 18:44 ` Ard Biesheuvel
2020-03-04 18:50 ` Arvind Sankar
2020-03-04 19:04 ` Ard Biesheuvel
2020-03-04 19:10 ` Arvind Sankar
2020-03-04 19:22 ` Ard Biesheuvel
2020-03-04 19:54 ` Arvind Sankar [this message]
2020-03-04 21:51 ` Ard Biesheuvel
2020-03-04 22:40 ` Arvind Sankar
2020-03-03 20:54 ` [PATCH 2/4] x86/mm/pat: Ensure that populate_pud only handles one PUD Arvind Sankar
2020-03-03 20:54 ` [PATCH 3/4] x86/mm/pat: Propagate all errors out of populate_pud Arvind Sankar
2020-03-03 20:54 ` [PATCH 4/4] x86/mm/pat: Make num_pages consistent in populate_{pte,pud,pgd} Arvind Sankar
2020-03-04 22:38 ` [PATCH 0/4] Bugfix + small cleanup to populate_p[mug]d Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200304195447.GA295419@rani.riverdale.lan \
--to=nivedita@alum.mit.edu \
--cc=ardb@kernel.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®