From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72400C3F2D7 for ; Thu, 5 Mar 2020 17:14:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3D92421556 for ; Thu, 5 Mar 2020 17:14:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583428461; bh=3zwAAGqgpufsx4y8pQbdwAnCKRxrgtV++eEAQuyZAsw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=prsW6QeD3dn2SEszb6s7H0ktfjygYNcSSaWQ9WQj0Ior2QQWdJZbwpLNaPZvDFy7x K9gUlgZ45HU0VuaWNvhWNTsNK0JOi/31hVUMbdPJAnXgVpBL6FZBQaRUEg861EU0RY gaBvnyk7ZEblEaLJrgj2XRk2AtPsWqR1aeMah5/Q= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727639AbgCEROT (ORCPT ); Thu, 5 Mar 2020 12:14:19 -0500 Received: from mail.kernel.org ([198.145.29.99]:40044 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726378AbgCEROI (ORCPT ); Thu, 5 Mar 2020 12:14:08 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 53ACA21556; Thu, 5 Mar 2020 17:14:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583428448; bh=3zwAAGqgpufsx4y8pQbdwAnCKRxrgtV++eEAQuyZAsw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dC9ymF3lflYnmBtGbh/F7fCURcd/qXu/he6r/Blm/XR1aiK3z+rpYc+iFsbMoVpun iwfhd7Tqdt/ba+xXAhL7w1b2geICCNdlGrMWAmtZkh3j4pXUuY5T1JVEEpV59GeXZI yJt58lvpCr5M1NGFPJI4Zr3Y3two9SU0lzWd8Cpc= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Masahiro Yamada , Rob Herring , Sasha Levin , linux-kbuild@vger.kernel.org Subject: [PATCH AUTOSEL 5.5 43/67] kbuild: fix DT binding schema rule to detect command line changes Date: Thu, 5 Mar 2020 12:12:44 -0500 Message-Id: <20200305171309.29118-43-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200305171309.29118-1-sashal@kernel.org> References: <20200305171309.29118-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Masahiro Yamada [ Upstream commit 7a04960560640ac5b0b89461f7757322b57d0c7a ] This if_change_rule is not working properly; it cannot detect any command line change. The reason is because cmd-check in scripts/Kbuild.include compares $(cmd_$@) and $(cmd_$1), but cmd_dtc_dt_yaml does not exist here. For if_change_rule to work properly, the stem part of cmd_* and rule_* must match. Because this cmd_and_fixdep invokes cmd_dtc, this rule must be named rule_dtc. Fixes: 4f0e3a57d6eb ("kbuild: Add support for DT binding schema checks") Signed-off-by: Masahiro Yamada Acked-by: Rob Herring Signed-off-by: Sasha Levin --- scripts/Makefile.lib | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib index 3fa32f83b2d74..a66fc0acad1e4 100644 --- a/scripts/Makefile.lib +++ b/scripts/Makefile.lib @@ -291,13 +291,13 @@ DT_TMP_SCHEMA := $(objtree)/$(DT_BINDING_DIR)/processed-schema.yaml quiet_cmd_dtb_check = CHECK $@ cmd_dtb_check = $(DT_CHECKER) -u $(srctree)/$(DT_BINDING_DIR) -p $(DT_TMP_SCHEMA) $@ ; -define rule_dtc_dt_yaml +define rule_dtc $(call cmd_and_fixdep,dtc,yaml) $(call cmd,dtb_check) endef $(obj)/%.dt.yaml: $(src)/%.dts $(DTC) $(DT_TMP_SCHEMA) FORCE - $(call if_changed_rule,dtc_dt_yaml) + $(call if_changed_rule,dtc) dtc-tmp = $(subst $(comma),_,$(dot-target).dts.tmp) -- 2.20.1