From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24A5AC3F2D2 for ; Thu, 5 Mar 2020 18:37:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ED5EF20726 for ; Thu, 5 Mar 2020 18:37:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="LQDw2YpP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727061AbgCEShj (ORCPT ); Thu, 5 Mar 2020 13:37:39 -0500 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:28616 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727018AbgCEShh (ORCPT ); Thu, 5 Mar 2020 13:37:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583433456; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Xfb+Soh2A345soHe2wUP+VAGGLoLquQzD+xTt+DA2Nw=; b=LQDw2YpPEeeiOD4M0hd8goh6ZvrhzzZqObKwi8o6a4ObfjFY8B1JS3wsjgThyXW+xHAI1w 3AYPTDb0/omBTBhNZiAhIgdGUdubtJ/uF4pB4g/jKFHZK5MBtscp+ZkEt8Zv2CV7KQmk57 txbrP8uhQb23XeslKjj19RZb93fDXl8= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-70-jTxVSqWGPMWtR54lTrZyVg-1; Thu, 05 Mar 2020 13:37:34 -0500 X-MC-Unique: jTxVSqWGPMWtR54lTrZyVg-1 Received: by mail-wm1-f71.google.com with SMTP id i16so551520wmd.9 for ; Thu, 05 Mar 2020 10:37:34 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Xfb+Soh2A345soHe2wUP+VAGGLoLquQzD+xTt+DA2Nw=; b=VL0g2Kntrkvf7HYOmTjvkq7N34EVvyJpZbfHAoVsRn48Z0iCX6mIH4DVFzodOXCXYx 4Iq2dTVUc72Xx5SABi39FXohsbzLvme0/Kt1q1h4P9fd9xLHEeNDNoZAOZSYA+epC9WM qK5dXRGj52PJmXeQwJn67w3NTbpCoIvsZczMTWBxKe8wAvrCC14u+ip9xNFf4RarvlMO cEV7I3SPRb685JapEXG7HeZ5ul/PqbXkRFAebI9wLnlJKqrA8/YDmz9Nh8LJ7ZsqBOtU X/+73X+tf31yb76jn8iDLtkuMcheRyvL6FekQcLPEuX6RnL7G7IeoSemb48rNFg2G2Y0 dI1Q== X-Gm-Message-State: ANhLgQ1gpbk/WXoco2jVX8S4bS/LsS2qCj6M+meCNCnQGpY0LgpifRyW MY1zjIkTQm4HDtuut2so/cGEpO6cxqWjFbXCU5080VZoL8rGHaSmFoJDI97oaUsCpEMfFmBEi8C CP8A5FoYp2Pk6VRY5Ae4Y5G5L X-Received: by 2002:a5d:49c5:: with SMTP id t5mr287910wrs.154.1583433453485; Thu, 05 Mar 2020 10:37:33 -0800 (PST) X-Google-Smtp-Source: ADFU+vuQ2QHCqVf+xa7VZrF0noYQ9aS405u86qPMgcOqSRhpc33vMZ/QkXSho/1PdQYGhzfZ8ToXUw== X-Received: by 2002:a5d:49c5:: with SMTP id t5mr287895wrs.154.1583433453240; Thu, 05 Mar 2020 10:37:33 -0800 (PST) Received: from vitty.brq.redhat.com (g-server-2.ign.cz. [91.219.240.2]) by smtp.gmail.com with ESMTPSA id u17sm9369121wmj.47.2020.03.05.10.37.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Mar 2020 10:37:32 -0800 (PST) From: Vitaly Kuznetsov To: Paolo Bonzini Cc: Jim Mattson , Sean Christopherson , Wanpeng Li , kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 2/2] KVM: VMX: untangle VMXON revision_id setting when using eVMCS Date: Thu, 5 Mar 2020 19:37:25 +0100 Message-Id: <20200305183725.28872-3-vkuznets@redhat.com> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200305183725.28872-1-vkuznets@redhat.com> References: <20200305183725.28872-1-vkuznets@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org As stated in alloc_vmxon_regions(), VMXON region needs to be tagged with revision id from MSR_IA32_VMX_BASIC even in case of eVMCS. The logic to do so is not very straightforward: first, we set hdr.revision_id = KVM_EVMCS_VERSION in alloc_vmcs_cpu() just to reset it back to vmcs_config.revision_id in alloc_vmxon_regions(). Simplify this by introducing 'enum vmcs_type' parameter to alloc_vmcs_cpu(). No functional change intended. Signed-off-by: Vitaly Kuznetsov --- arch/x86/kvm/vmx/vmx.c | 32 ++++++++++++++------------------ arch/x86/kvm/vmx/vmx.h | 12 +++++++++--- 2 files changed, 23 insertions(+), 21 deletions(-) diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c index dab19e4e5f2b..697be8823576 100644 --- a/arch/x86/kvm/vmx/vmx.c +++ b/arch/x86/kvm/vmx/vmx.c @@ -2554,7 +2554,7 @@ static __init int setup_vmcs_config(struct vmcs_config *vmcs_conf, return 0; } -struct vmcs *alloc_vmcs_cpu(bool shadow, int cpu, gfp_t flags) +struct vmcs *alloc_vmcs_cpu(enum vmcs_type type, int cpu, gfp_t flags) { int node = cpu_to_node(cpu); struct page *pages; @@ -2566,13 +2566,21 @@ struct vmcs *alloc_vmcs_cpu(bool shadow, int cpu, gfp_t flags) vmcs = page_address(pages); memset(vmcs, 0, vmcs_config.size); - /* KVM supports Enlightened VMCS v1 only */ - if (static_branch_unlikely(&enable_evmcs)) + /* + * When eVMCS is enabled, vmcs->revision_id needs to be set to the + * supported eVMCS version (KVM_EVMCS_VERSION) instead of revision_id + * reported by MSR_IA32_VMX_BASIC. + * + * However, even though not explicitly documented by TLFS, VMXArea + * passed as VMXON argument should still be marked with revision_id + * reported by physical CPU. + */ + if (type != VMXON_REGION && static_branch_unlikely(&enable_evmcs)) vmcs->hdr.revision_id = KVM_EVMCS_VERSION; else vmcs->hdr.revision_id = vmcs_config.revision_id; - if (shadow) + if (type == SHADOW_VMCS_REGION) vmcs->hdr.shadow_vmcs = 1; return vmcs; } @@ -2652,25 +2660,13 @@ static __init int alloc_vmxon_regions(void) for_each_possible_cpu(cpu) { struct vmcs *vmcs; - vmcs = alloc_vmcs_cpu(false, cpu, GFP_KERNEL); + /* The VMXON region is really just a special type of VMCS. */ + vmcs = alloc_vmcs_cpu(VMXON_REGION, cpu, GFP_KERNEL); if (!vmcs) { free_vmxon_regions(); return -ENOMEM; } - /* - * When eVMCS is enabled, alloc_vmcs_cpu() sets - * vmcs->revision_id to KVM_EVMCS_VERSION instead of - * revision_id reported by MSR_IA32_VMX_BASIC. - * - * However, even though not explicitly documented by - * TLFS, VMXArea passed as VMXON argument should - * still be marked with revision_id reported by - * physical CPU. - */ - if (static_branch_unlikely(&enable_evmcs)) - vmcs->hdr.revision_id = vmcs_config.revision_id; - per_cpu(vmxarea, cpu) = vmcs; } return 0; diff --git a/arch/x86/kvm/vmx/vmx.h b/arch/x86/kvm/vmx/vmx.h index e64da06c7009..4c327030bb9c 100644 --- a/arch/x86/kvm/vmx/vmx.h +++ b/arch/x86/kvm/vmx/vmx.h @@ -489,7 +489,13 @@ static inline struct pi_desc *vcpu_to_pi_desc(struct kvm_vcpu *vcpu) return &(to_vmx(vcpu)->pi_desc); } -struct vmcs *alloc_vmcs_cpu(bool shadow, int cpu, gfp_t flags); +enum vmcs_type { + VMXON_REGION, + VMCS_REGION, + SHADOW_VMCS_REGION, +}; + +struct vmcs *alloc_vmcs_cpu(enum vmcs_type type, int cpu, gfp_t flags); void free_vmcs(struct vmcs *vmcs); int alloc_loaded_vmcs(struct loaded_vmcs *loaded_vmcs); void free_loaded_vmcs(struct loaded_vmcs *loaded_vmcs); @@ -498,8 +504,8 @@ void loaded_vmcs_clear(struct loaded_vmcs *loaded_vmcs); static inline struct vmcs *alloc_vmcs(bool shadow) { - return alloc_vmcs_cpu(shadow, raw_smp_processor_id(), - GFP_KERNEL_ACCOUNT); + return alloc_vmcs_cpu(shadow ? SHADOW_VMCS_REGION : VMCS_REGION, + raw_smp_processor_id(), GFP_KERNEL_ACCOUNT); } u64 construct_eptp(struct kvm_vcpu *vcpu, unsigned long root_hpa); -- 2.24.1