From: Daniel Vetter <daniel@ffwll.ch>
To: Benjamin Gaignard <benjamin.gaignard@st.com>
Cc: maarten.lankhorst@linux.intel.com, mripard@kernel.org,
tzimmermann@suse.de, airlied@linux.ie, daniel@ffwll.ch,
emil.l.velikov@gmail.com, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] drm: context: Clean up documentation
Date: Fri, 6 Mar 2020 12:08:17 +0100 [thread overview]
Message-ID: <20200306110817.GZ2363188@phenom.ffwll.local> (raw)
In-Reply-To: <20200306102937.4932-4-benjamin.gaignard@st.com>
On Fri, Mar 06, 2020 at 11:29:37AM +0100, Benjamin Gaignard wrote:
> Fix kernel doc comments to avoid warnings when compiling with W=1.
>
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>
> ---
> version 2:
> - Since it is legacy interface do not fix the description but
> replace /** by /* to remove kerneldoc validation warnings
On the entire series:
Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>
> drivers/gpu/drm/drm_context.c | 28 ++++++++++++++--------------
> 1 file changed, 14 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_context.c b/drivers/gpu/drm/drm_context.c
> index 1f802d8e5681..c99be950bf17 100644
> --- a/drivers/gpu/drm/drm_context.c
> +++ b/drivers/gpu/drm/drm_context.c
> @@ -47,7 +47,7 @@ struct drm_ctx_list {
> /** \name Context bitmap support */
> /*@{*/
>
> -/**
> +/*
> * Free a handle from the context bitmap.
> *
> * \param dev DRM device.
> @@ -68,7 +68,7 @@ void drm_legacy_ctxbitmap_free(struct drm_device * dev, int ctx_handle)
> mutex_unlock(&dev->struct_mutex);
> }
>
> -/**
> +/*
> * Context bitmap allocation.
> *
> * \param dev DRM device.
> @@ -88,7 +88,7 @@ static int drm_legacy_ctxbitmap_next(struct drm_device * dev)
> return ret;
> }
>
> -/**
> +/*
> * Context bitmap initialization.
> *
> * \param dev DRM device.
> @@ -104,7 +104,7 @@ void drm_legacy_ctxbitmap_init(struct drm_device * dev)
> idr_init(&dev->ctx_idr);
> }
>
> -/**
> +/*
> * Context bitmap cleanup.
> *
> * \param dev DRM device.
> @@ -163,7 +163,7 @@ void drm_legacy_ctxbitmap_flush(struct drm_device *dev, struct drm_file *file)
> /** \name Per Context SAREA Support */
> /*@{*/
>
> -/**
> +/*
> * Get per-context SAREA.
> *
> * \param inode device inode.
> @@ -211,7 +211,7 @@ int drm_legacy_getsareactx(struct drm_device *dev, void *data,
> return 0;
> }
>
> -/**
> +/*
> * Set per-context SAREA.
> *
> * \param inode device inode.
> @@ -263,7 +263,7 @@ int drm_legacy_setsareactx(struct drm_device *dev, void *data,
> /** \name The actual DRM context handling routines */
> /*@{*/
>
> -/**
> +/*
> * Switch context.
> *
> * \param dev DRM device.
> @@ -290,7 +290,7 @@ static int drm_context_switch(struct drm_device * dev, int old, int new)
> return 0;
> }
>
> -/**
> +/*
> * Complete context switch.
> *
> * \param dev DRM device.
> @@ -318,7 +318,7 @@ static int drm_context_switch_complete(struct drm_device *dev,
> return 0;
> }
>
> -/**
> +/*
> * Reserve contexts.
> *
> * \param inode device inode.
> @@ -351,7 +351,7 @@ int drm_legacy_resctx(struct drm_device *dev, void *data,
> return 0;
> }
>
> -/**
> +/*
> * Add context.
> *
> * \param inode device inode.
> @@ -404,7 +404,7 @@ int drm_legacy_addctx(struct drm_device *dev, void *data,
> return 0;
> }
>
> -/**
> +/*
> * Get context.
> *
> * \param inode device inode.
> @@ -428,7 +428,7 @@ int drm_legacy_getctx(struct drm_device *dev, void *data,
> return 0;
> }
>
> -/**
> +/*
> * Switch context.
> *
> * \param inode device inode.
> @@ -452,7 +452,7 @@ int drm_legacy_switchctx(struct drm_device *dev, void *data,
> return drm_context_switch(dev, dev->last_context, ctx->handle);
> }
>
> -/**
> +/*
> * New context.
> *
> * \param inode device inode.
> @@ -478,7 +478,7 @@ int drm_legacy_newctx(struct drm_device *dev, void *data,
> return 0;
> }
>
> -/**
> +/*
> * Remove context.
> *
> * \param inode device inode.
> --
> 2.15.0
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
next prev parent reply other threads:[~2020-03-06 11:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-06 10:29 [PATCH] drm: vm: " Benjamin Gaignard
2020-03-06 10:29 ` [PATCH] drm: lock: " Benjamin Gaignard
2020-03-06 10:29 ` [PATCH] drm: bufs: " Benjamin Gaignard
2020-03-06 10:29 ` [PATCH v2] drm: context: " Benjamin Gaignard
2020-03-06 11:08 ` Daniel Vetter [this message]
2020-03-16 8:29 ` Benjamin GAIGNARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200306110817.GZ2363188@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=airlied@linux.ie \
--cc=benjamin.gaignard@st.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.l.velikov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®