From: Mark Rutland <mark.rutland@arm.com>
To: luanshi <zhangliguang@linux.alibaba.com>
Cc: Will Deacon <will@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf: arm_spe: remove unnecessary zero check
Date: Mon, 9 Mar 2020 10:52:20 +0000 [thread overview]
Message-ID: <20200309105219.GC25261@lakrids.cambridge.arm.com> (raw)
In-Reply-To: <1582691106-3432-1-git-send-email-zhangliguang@linux.alibaba.com>
On Wed, Feb 26, 2020 at 12:25:06PM +0800, luanshi wrote:
> The "nr_pages" variable has been checked before, it can't be zero, so a check here would be useless.
>
> Signed-off-by: Liguang Zhang <zhangliguang@linux.alibaba.com>
As the commit message states, a done:
| /* We need at least two pages for this to work. */
| if (nr_pages < 2)
| return NULL;
... so this looks sensible to me:
Acked-by: Mark Rutland <mark.rutland@arm.com>
Mark.
> ---
> drivers/perf/arm_spe_pmu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/perf/arm_spe_pmu.c b/drivers/perf/arm_spe_pmu.c
> index 4e4984a..b72c048 100644
> --- a/drivers/perf/arm_spe_pmu.c
> +++ b/drivers/perf/arm_spe_pmu.c
> @@ -831,7 +831,7 @@ static void *arm_spe_pmu_setup_aux(struct perf_event *event, void **pages,
> * parts and give userspace a fighting chance of getting some
> * useful data out of it.
> */
> - if (!nr_pages || (snapshot && (nr_pages & 1)))
> + if (snapshot && (nr_pages & 1))
> return NULL;
>
> if (cpu == -1)
> --
> 1.8.3.1
>
prev parent reply other threads:[~2020-03-09 10:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-26 4:25 luanshi
2020-03-09 10:52 ` Mark Rutland [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200309105219.GC25261@lakrids.cambridge.arm.com \
--to=mark.rutland@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=will@kernel.org \
--cc=zhangliguang@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®