From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80051C10F27 for ; Mon, 9 Mar 2020 11:09:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4831220828 for ; Mon, 9 Mar 2020 11:09:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583752146; bh=xeVZYWJE37/+2qxtaIzD+1Mnqj/kL4iSm38yjyMa79Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=Cy4CKehfyyu4e3Q10uMngSBPHdaLmE0pDcm9WvhSjxhaWWbp03yS1YSYZ+CNGG9Im iABmdbsBFRx3OBW7C1id3CTzx+6rGyszTYDzlEyFbbLvMf9jQngDKq4add+fYdGuEE f2uJirSMGgT/ZzyBlxzgktxNQhCKY6Y2eKNKpWuU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726582AbgCILJF (ORCPT ); Mon, 9 Mar 2020 07:09:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:57392 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726217AbgCILJE (ORCPT ); Mon, 9 Mar 2020 07:09:04 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4244D2051A; Mon, 9 Mar 2020 11:09:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583752143; bh=xeVZYWJE37/+2qxtaIzD+1Mnqj/kL4iSm38yjyMa79Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jRcg39Xl3X9VgRSwUKqtV08Kn14AAr5t7Ak7jX+1fFGZGLXGl5NSUg5rcUmX8mDpT Gh066Zt1E8ORO4VVRuoo/R4nqYuXS45StHTNHMtwkXUJj6vI4Aanea0pAEuSFXR6xh ys+1Ymq+k9AAI4LwM1c3azhfv5O1bj0CG1+NwxwQ= Date: Mon, 9 Mar 2020 12:09:01 +0100 From: Greg Kroah-Hartman To: Quentin Deslandes Cc: devel@driverdev.osuosl.org, Oscar Carter , Malcolm Priestley , linux-kernel@vger.kernel.org, Forest Bond , Gabriela Bittencourt , Colin Ian King Subject: Re: [PATCH] staging: vt6656: Declare a few variables as __read_mostly Message-ID: <20200309110901.GB183429@kroah.com> References: <20200301112620.7892-1-oscar.carter@gmx.com> <20200301122514.GA1461917@kroah.com> <20200301131701.GA7487@ubuntu> <20200301150913.GA1470815@kroah.com> <20200307082906.GA2948@ubuntu> <20200309093210.GA7693@qd-ubuntu> <20200309103407.GB180589@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200309103407.GB180589@kroah.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 09, 2020 at 11:34:07AM +0100, Greg Kroah-Hartman wrote: > On Mon, Mar 09, 2020 at 09:32:10AM +0000, Quentin Deslandes wrote: > > On Sat, Mar 07, 2020 at 09:29:06AM +0100, Oscar Carter wrote: > > > On Sun, Mar 01, 2020 at 04:09:13PM +0100, Greg Kroah-Hartman wrote: > > > > On Sun, Mar 01, 2020 at 02:17:01PM +0100, Oscar Carter wrote: > > > > This is a USB driver, performance is always limited to the hardware, not > > > > the CPU location of variables. > > > > > > Thank you for the explanation. > > > > > > > > > > > Please always benchmark things to see if it actually makes sense to make > > > > changes like this, before proposing them. > > > > > > I'm sorry. > > > > > > > I've been removed from CC list on Greg's answer, so I haven't seen the > > explanation earlier and reviewed the patch the next day. I should have > > know better, won't happen again. > > You weren't on the original list of people on the patch, so I didn't > remove anything here that I can tell. Turns out you were, on the lkml one, but not the one that went through the driver-devel list. odd...