From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68B2EC18E5A for ; Tue, 10 Mar 2020 11:16:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2FC3F24696 for ; Tue, 10 Mar 2020 11:16:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583839016; bh=3HU8l+PRlUZF/+sJDVXRi7UJybi0MMIZ1weHoYV2yn4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=Hm63Bdw54Xk5lRUWhoxgd15hS472+Nd86x+GxgRDR7hpf8qRJjFERcrif5ABC+s8K V5Q9vVO2JY4oQifn/lE/q5GV3OanqMwEw1YvkU4/cLHS9E3bplGzbLhAAiezX5U1gL yGaqI60bjaZuhn+juXkbKuOSnJZP5Sv2Z193ZCDc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726703AbgCJLQz (ORCPT ); Tue, 10 Mar 2020 07:16:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:54806 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726834AbgCJLQw (ORCPT ); Tue, 10 Mar 2020 07:16:52 -0400 Received: from quaco.ghostprotocols.net (unknown [179.97.37.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 55CB024692; Tue, 10 Mar 2020 11:16:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583839011; bh=3HU8l+PRlUZF/+sJDVXRi7UJybi0MMIZ1weHoYV2yn4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gLQECZknCIUogrHtY3XWspHjpJH4Sy6FpaSEMGvhf32FcIXeU1TGb1w26LQg6JZDI nD1/Z/jXNnBn8Q0KmVvDWmTgm3PNkp2iSXOMZ12bJy0Mc+WYYp+H5N0DqJDP84/jFk lZ60FBnA1Tfh06opHtnqfAGZedrnRljujxGIQVRs= From: Arnaldo Carvalho de Melo To: Ingo Molnar , Thomas Gleixner Cc: Jiri Olsa , Namhyung Kim , Clark Williams , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Andi Kleen , Alexander Shishkin , John Garry , Kajol Jain , Michael Petlan , Peter Zijlstra , Ravi Bangoria , Arnaldo Carvalho de Melo Subject: [PATCH 13/19] perf expr: Increase EXPR_MAX_OTHER to support metrics with more than 15 variables Date: Tue, 10 Mar 2020 08:15:45 -0300 Message-Id: <20200310111551.25160-14-acme@kernel.org> X-Mailer: git-send-email 2.21.1 In-Reply-To: <20200310111551.25160-1-acme@kernel.org> References: <20200310111551.25160-1-acme@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jiri Olsa We have metrics that define more than 15 variables, like Branch_Misprediction_Cost. Increasing the allowed variables count to 20. As Andy pointed out, we can't go too high in here, because some of the code has O(n^2) complexity (already_seen) and we might want to do some other changes (like using hash tables) before increasing the maximum even more. Signed-off-by: Jiri Olsa Reviewed-by: Andi Kleen Cc: Alexander Shishkin Cc: John Garry Cc: Kajol Jain Cc: Michael Petlan Cc: Namhyung Kim Cc: Peter Zijlstra Cc: Ravi Bangoria Link: http://lore.kernel.org/lkml/20200228093616.67125-4-jolsa@kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/util/expr.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/util/expr.h b/tools/perf/util/expr.h index 9332796e6649..df0a17df0cef 100644 --- a/tools/perf/util/expr.h +++ b/tools/perf/util/expr.h @@ -2,7 +2,7 @@ #ifndef PARSE_CTX_H #define PARSE_CTX_H 1 -#define EXPR_MAX_OTHER 15 +#define EXPR_MAX_OTHER 20 #define MAX_PARSE_ID EXPR_MAX_OTHER struct parse_id { -- 2.21.1