From: Wambui Karuga <wambui.karugax@gmail.com>
To: airlied@linux.ie, daniel@ffwll.ch,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
gregkh@linuxfoundation.org
Subject: [PATCH v2 01/17] drm/tegra: remove checks for debugfs functions return value
Date: Tue, 10 Mar 2020 16:31:05 +0300 [thread overview]
Message-ID: <20200310133121.27913-2-wambui.karugax@gmail.com> (raw)
In-Reply-To: <20200310133121.27913-1-wambui.karugax@gmail.com>
Since 987d65d01356 (drm: debugfs: make
drm_debugfs_create_files() never fail) there is no need to check the
return value of drm_debugfs_create_files(). Therefore, remove the
return checks and error handling of the drm_debugfs_create_files()
function from various debugfs init functions in drm/tegra and have
them return 0 directly.
v2: remove conversion of tegra_debugfs_init() to void to avoid build
breakage.
References: https://lists.freedesktop.org/archives/dri-devel/2020-February/257183.html
Signed-off-by: Wambui Karuga <wambui.karugax@gmail.com>
---
drivers/gpu/drm/tegra/dc.c | 11 +----------
drivers/gpu/drm/tegra/drm.c | 7 ++++---
drivers/gpu/drm/tegra/dsi.c | 11 +----------
drivers/gpu/drm/tegra/hdmi.c | 11 +----------
drivers/gpu/drm/tegra/sor.c | 11 +----------
5 files changed, 8 insertions(+), 43 deletions(-)
diff --git a/drivers/gpu/drm/tegra/dc.c b/drivers/gpu/drm/tegra/dc.c
index 7c70fd31a4c2..e70d58b21964 100644
--- a/drivers/gpu/drm/tegra/dc.c
+++ b/drivers/gpu/drm/tegra/dc.c
@@ -1496,7 +1496,6 @@ static int tegra_dc_late_register(struct drm_crtc *crtc)
struct drm_minor *minor = crtc->dev->primary;
struct dentry *root;
struct tegra_dc *dc = to_tegra_dc(crtc);
- int err;
#ifdef CONFIG_DEBUG_FS
root = crtc->debugfs_entry;
@@ -1512,17 +1511,9 @@ static int tegra_dc_late_register(struct drm_crtc *crtc)
for (i = 0; i < count; i++)
dc->debugfs_files[i].data = dc;
- err = drm_debugfs_create_files(dc->debugfs_files, count, root, minor);
- if (err < 0)
- goto free;
+ drm_debugfs_create_files(dc->debugfs_files, count, root, minor);
return 0;
-
-free:
- kfree(dc->debugfs_files);
- dc->debugfs_files = NULL;
-
- return err;
}
static void tegra_dc_early_unregister(struct drm_crtc *crtc)
diff --git a/drivers/gpu/drm/tegra/drm.c b/drivers/gpu/drm/tegra/drm.c
index bd268028fb3d..6ec224f3d824 100644
--- a/drivers/gpu/drm/tegra/drm.c
+++ b/drivers/gpu/drm/tegra/drm.c
@@ -841,9 +841,10 @@ static struct drm_info_list tegra_debugfs_list[] = {
static int tegra_debugfs_init(struct drm_minor *minor)
{
- return drm_debugfs_create_files(tegra_debugfs_list,
- ARRAY_SIZE(tegra_debugfs_list),
- minor->debugfs_root, minor);
+ drm_debugfs_create_files(tegra_debugfs_list,
+ ARRAY_SIZE(tegra_debugfs_list),
+ minor->debugfs_root, minor);
+ return 0;
}
#endif
diff --git a/drivers/gpu/drm/tegra/dsi.c b/drivers/gpu/drm/tegra/dsi.c
index 88b9d64c77bf..30626fcf61eb 100644
--- a/drivers/gpu/drm/tegra/dsi.c
+++ b/drivers/gpu/drm/tegra/dsi.c
@@ -234,7 +234,6 @@ static int tegra_dsi_late_register(struct drm_connector *connector)
struct drm_minor *minor = connector->dev->primary;
struct dentry *root = connector->debugfs_entry;
struct tegra_dsi *dsi = to_dsi(output);
- int err;
dsi->debugfs_files = kmemdup(debugfs_files, sizeof(debugfs_files),
GFP_KERNEL);
@@ -244,17 +243,9 @@ static int tegra_dsi_late_register(struct drm_connector *connector)
for (i = 0; i < count; i++)
dsi->debugfs_files[i].data = dsi;
- err = drm_debugfs_create_files(dsi->debugfs_files, count, root, minor);
- if (err < 0)
- goto free;
+ drm_debugfs_create_files(dsi->debugfs_files, count, root, minor);
return 0;
-
-free:
- kfree(dsi->debugfs_files);
- dsi->debugfs_files = NULL;
-
- return err;
}
static void tegra_dsi_early_unregister(struct drm_connector *connector)
diff --git a/drivers/gpu/drm/tegra/hdmi.c b/drivers/gpu/drm/tegra/hdmi.c
index 6f117628f257..d7799d13d8ad 100644
--- a/drivers/gpu/drm/tegra/hdmi.c
+++ b/drivers/gpu/drm/tegra/hdmi.c
@@ -1064,7 +1064,6 @@ static int tegra_hdmi_late_register(struct drm_connector *connector)
struct drm_minor *minor = connector->dev->primary;
struct dentry *root = connector->debugfs_entry;
struct tegra_hdmi *hdmi = to_hdmi(output);
- int err;
hdmi->debugfs_files = kmemdup(debugfs_files, sizeof(debugfs_files),
GFP_KERNEL);
@@ -1074,17 +1073,9 @@ static int tegra_hdmi_late_register(struct drm_connector *connector)
for (i = 0; i < count; i++)
hdmi->debugfs_files[i].data = hdmi;
- err = drm_debugfs_create_files(hdmi->debugfs_files, count, root, minor);
- if (err < 0)
- goto free;
+ drm_debugfs_create_files(hdmi->debugfs_files, count, root, minor);
return 0;
-
-free:
- kfree(hdmi->debugfs_files);
- hdmi->debugfs_files = NULL;
-
- return err;
}
static void tegra_hdmi_early_unregister(struct drm_connector *connector)
diff --git a/drivers/gpu/drm/tegra/sor.c b/drivers/gpu/drm/tegra/sor.c
index 81226a4953c1..47c1d133069a 100644
--- a/drivers/gpu/drm/tegra/sor.c
+++ b/drivers/gpu/drm/tegra/sor.c
@@ -1687,7 +1687,6 @@ static int tegra_sor_late_register(struct drm_connector *connector)
struct drm_minor *minor = connector->dev->primary;
struct dentry *root = connector->debugfs_entry;
struct tegra_sor *sor = to_sor(output);
- int err;
sor->debugfs_files = kmemdup(debugfs_files, sizeof(debugfs_files),
GFP_KERNEL);
@@ -1697,17 +1696,9 @@ static int tegra_sor_late_register(struct drm_connector *connector)
for (i = 0; i < count; i++)
sor->debugfs_files[i].data = sor;
- err = drm_debugfs_create_files(sor->debugfs_files, count, root, minor);
- if (err < 0)
- goto free;
+ drm_debugfs_create_files(sor->debugfs_files, count, root, minor);
return 0;
-
-free:
- kfree(sor->debugfs_files);
- sor->debugfs_files = NULL;
-
- return err;
}
static void tegra_sor_early_unregister(struct drm_connector *connector)
--
2.25.1
next prev parent reply other threads:[~2020-03-10 13:31 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-10 13:31 [PATCH v2 00/17] drm: subsytem-wide debugfs functions refactor Wambui Karuga
2020-03-10 13:31 ` Wambui Karuga [this message]
2020-03-10 13:31 ` [PATCH v2 02/17] drm/tilcdc: remove check for return value of debugfs functions Wambui Karuga
2020-03-10 13:31 ` [PATCH v2 03/17] drm/v3d: make v3d_debugfs_init() return 0 Wambui Karuga
2020-03-10 13:31 ` [PATCH v2 04/17] drm/vc4: remove check of return value of drm_debugfs functions Wambui Karuga
2020-03-10 13:31 ` [PATCH v2 05/17] drm/arc: make arcgpu_debugfs_init() return 0 Wambui Karuga
2020-03-12 7:55 ` Alexey Brodkin
2020-03-10 13:31 ` [PATCH v2 06/17] drm/arm: make hdlcd_debugfs_init() " Wambui Karuga
2020-03-10 15:43 ` Liviu Dudau
2020-03-10 13:31 ` [PATCH v2 07/17] drm/etnaviv: remove check for return value of drm_debugfs_create_files() Wambui Karuga
2020-03-11 16:44 ` Lucas Stach
2020-03-10 13:31 ` [PATCH v2 08/17] drm/msm: remove checks " Wambui Karuga
2020-03-10 13:31 ` [PATCH v2 09/17] drm/sti: remove use of drm_debugfs functions as return values Wambui Karuga
2020-03-10 13:31 ` [PATCH v2 10/17] drm/vram-helper: make drm_vram_mm_debugfs_init() return 0 Wambui Karuga
2020-03-18 15:26 ` Daniel Vetter
2020-03-18 16:02 ` Wambui Karuga
2020-03-18 16:31 ` Daniel Vetter
2020-03-18 16:58 ` Greg KH
2020-03-18 19:10 ` Daniel Vetter
2020-03-19 7:55 ` Greg KH
2020-03-19 10:18 ` Daniel Vetter
2020-03-19 12:27 ` Wambui Karuga
2020-04-07 6:36 ` Thomas Zimmermann
2020-03-10 13:31 ` [PATCH v2 11/17] drm/nouveau: make nouveau_drm_debugfs_init() " Wambui Karuga
2020-03-10 13:31 ` [PATCH v2 12/17] drm/pl111: make pl111_debugfs_init " Wambui Karuga
2020-03-10 13:31 ` [PATCH v2 13/17] drm/omap: remove checks for return value of drm_debugfs functions Wambui Karuga
2020-03-10 13:31 ` [PATCH v2 14/17] drm/i915: have *_debugfs_init() functions return void Wambui Karuga
2020-03-11 8:15 ` Jani Nikula
2020-03-10 13:31 ` [PATCH v2 15/17] drm: make various debugfs_init() functions return 0 Wambui Karuga
2020-03-10 13:31 ` [PATCH v2 16/17] drm/debugfs: remove checks for return value of drm_debugfs functions Wambui Karuga
2020-03-10 13:31 ` [PATCH v2 17/17] drm: convert .debugfs_init() hook to return void Wambui Karuga
2020-03-10 14:33 ` [PATCH v2 00/17] drm: subsytem-wide debugfs functions refactor Greg KH
2020-03-18 16:54 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200310133121.27913-2-wambui.karugax@gmail.com \
--to=wambui.karugax@gmail.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®