From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C924C10F27 for ; Tue, 10 Mar 2020 18:12:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5EDDE20637 for ; Tue, 10 Mar 2020 18:12:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726801AbgCJSMo (ORCPT ); Tue, 10 Mar 2020 14:12:44 -0400 Received: from alexa-out-sd-01.qualcomm.com ([199.106.114.38]:38739 "EHLO alexa-out-sd-01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726464AbgCJSMo (ORCPT ); Tue, 10 Mar 2020 14:12:44 -0400 Received: from unknown (HELO ironmsg05-sd.qualcomm.com) ([10.53.140.145]) by alexa-out-sd-01.qualcomm.com with ESMTP; 10 Mar 2020 11:12:43 -0700 Received: from gurus-linux.qualcomm.com ([10.46.162.81]) by ironmsg05-sd.qualcomm.com with ESMTP; 10 Mar 2020 11:12:42 -0700 Received: by gurus-linux.qualcomm.com (Postfix, from userid 383780) id DE2854AAD; Tue, 10 Mar 2020 11:12:42 -0700 (PDT) Date: Tue, 10 Mar 2020 11:12:42 -0700 From: Guru Das Srinagesh To: Daniel Thompson Cc: linux-pwm@vger.kernel.org, Thierry Reding , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Subbaraman Narayanamurthy , linux-kernel@vger.kernel.org, Lee Jones , Jingoo Han , Bartlomiej Zolnierkiewicz , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Subject: Re: [PATCH v7 12/13] backlight: pwm_bl: Use 64-bit division macros for period and duty cycle Message-ID: <20200310181242.GA31738@codeaurora.org> References: <20200310143432.cfjlqac5x6oinshj@holly.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200310143432.cfjlqac5x6oinshj@holly.lan> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 10, 2020 at 02:34:32PM +0000, Daniel Thompson wrote: > This patch looks like it is a tiny change to get the pwm_backlight to > perform 64-bit division. Most of the above text is completely irrelevant > to the change contained in this patch. No need to justify the change in > the PWM structures here since that can go in the patch that changes > those structures. Just describe what this patch does, perhaps something > like the following: > > The PWM API will shortly switch the state.period and > state.duty_cycle fields to 64-bit values. Make pwm_bl > ready for this transition by adopting 64-bit division > macros. Will update the commit text accordingly. > Also please copy the backlight maintainers into the covering letter. It > is useful to place patches like this into context. Will do. Thank you. Guru Das.