From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7298C10DCE for ; Thu, 12 Mar 2020 06:50:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B0DC020578 for ; Thu, 12 Mar 2020 06:50:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387994AbgCLGud (ORCPT ); Thu, 12 Mar 2020 02:50:33 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:56354 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387889AbgCLGud (ORCPT ); Thu, 12 Mar 2020 02:50:33 -0400 Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 0F8C914DD5D48; Wed, 11 Mar 2020 23:50:32 -0700 (PDT) Date: Wed, 11 Mar 2020 23:50:31 -0700 (PDT) Message-Id: <20200311.235031.754217366237670514.davem@davemloft.net> To: paolo.lungaroni@cnit.it Cc: kuba@kernel.org, kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, andrea.mayer@uniroma2.it, ahmed.abdelsalam@gssi.it Subject: Re: [net] seg6: fix SRv6 L2 tunnels to use IANA-assigned protocol number From: David Miller In-Reply-To: <20200311165406.22044-1-paolo.lungaroni@cnit.it> References: <20200311165406.22044-1-paolo.lungaroni@cnit.it> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 11 Mar 2020 23:50:32 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Paolo Lungaroni Date: Wed, 11 Mar 2020 17:54:06 +0100 > The Internet Assigned Numbers Authority (IANA) has recently assigned > a protocol number value of 143 for Ethernet [1]. > > Before this assignment, encapsulation mechanisms such as Segment Routing > used the IPv6-NoNxt protocol number (59) to indicate that the encapsulated > payload is an Ethernet frame. > > In this patch, we add the definition of the Ethernet protocol number to the > kernel headers and update the SRv6 L2 tunnels to use it. > > [1] https://www.iana.org/assignments/protocol-numbers/protocol-numbers.xhtml > > Signed-off-by: Paolo Lungaroni > Reviewed-by: Andrea Mayer > Acked-by: Ahmed Abdelsalam Applied. But this is that classic case where we add a protocol element to the tree before the official number is assigned. Then the number is assigned and if we change it then everything using the original number is no longer interoperable.