From: David Miller <davem@davemloft.net>
To: bmeneg@redhat.com
Cc: linux-kernel@vger.kernel.org, bpf@vger.kernel.org,
netdev@vger.kernel.org, GLin@suse.com, kuba@kernel.org,
ast@kernel.org
Subject: Re: [PATCH] net/bpfilter: fix dprintf usage for logging into /dev/kmsg
Date: Thu, 12 Mar 2020 15:34:56 -0700 (PDT) [thread overview]
Message-ID: <20200312.153456.472585037753603767.davem@davemloft.net> (raw)
In-Reply-To: <20200312201240.1960367-1-bmeneg@redhat.com>
From: Bruno Meneguele <bmeneg@redhat.com>
Date: Thu, 12 Mar 2020 17:12:40 -0300
> The bpfilter UMH code was recently changed to log its informative messages to
> /dev/kmsg, however this interface doesn't support SEEK_CUR yet, used by
> dprintf(). As result dprintf() returns -EINVAL and doesn't log anything.
>
> Although there already had some discussions about supporting SEEK_CUR into
> /dev/kmsg in the past, it wasn't concluded. Considering the only
> user of that interface from userspace perspective inside the kernel is the
> bpfilter UMH (userspace) module it's better to correct it here instead of
> waiting a conclusion on the interface changes.
>
> Signed-off-by: Bruno Meneguele <bmeneg@redhat.com>
Please repost this with a proper Fixes: tag.
Thank you.
prev parent reply other threads:[~2020-03-12 22:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-12 20:12 Bruno Meneguele
2020-03-12 22:34 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200312.153456.472585037753603767.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=GLin@suse.com \
--cc=ast@kernel.org \
--cc=bmeneg@redhat.com \
--cc=bpf@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®