From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F83EC5ACBF for ; Fri, 13 Mar 2020 13:03:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5361720724 for ; Fri, 13 Mar 2020 13:03:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726571AbgCMNDR (ORCPT ); Fri, 13 Mar 2020 09:03:17 -0400 Received: from mail.baikalelectronics.com ([87.245.175.226]:60776 "EHLO mail.baikalelectronics.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726479AbgCMNDR (ORCPT ); Fri, 13 Mar 2020 09:03:17 -0400 Received: from localhost (unknown [127.0.0.1]) by mail.baikalelectronics.ru (Postfix) with ESMTP id 67C3E80307C4; Fri, 13 Mar 2020 13:03:14 +0000 (UTC) X-Virus-Scanned: amavisd-new at baikalelectronics.ru Received: from mail.baikalelectronics.ru ([127.0.0.1]) by localhost (mail.baikalelectronics.ru [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id m3F-eTf_XM1G; Fri, 13 Mar 2020 16:03:13 +0300 (MSK) Date: Fri, 13 Mar 2020 16:02:31 +0300 From: Sergey Semin To: Rob Herring CC: Sebastian Reichel , Mark Rutland , Alexey Malahov , Thomas Bogendoerfer , Paul Burton , Ralf Baechle , , , Subject: Re: [PATCH 3/4] dt-bindings: power: reset: Add regmap support to the SYSCON reboot-mode bindings Message-ID: <20200313130231.wrvvcttm7ofaxbfo@ubsrv2.baikal.int> References: <20200306130341.9585-1-Sergey.Semin@baikalelectronics.ru> <20200306130402.1F4F0803079F@mail.baikalelectronics.ru> <20200312211438.GA21883@bogus> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20200312211438.GA21883@bogus> X-ClientProxiedBy: MAIL.baikal.int (192.168.51.25) To mail (192.168.51.25) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 12, 2020 at 04:14:38PM -0500, Rob Herring wrote: > On Fri, Mar 06, 2020 at 04:03:40PM +0300, Sergey.Semin@baikalelectronics.ru wrote: > > From: Serge Semin > > > > Optional regmap property will be used to refer to a syscon-controller > > having a reboot tolerant register mapped. > > NAK. It should simply be a child node of the 'syscon-controller'. Hm, It's dilemma. The driver maintainer said ack, while you disagree.) So the code change will be merged while the doc-part won't? Lets discuss then to settle the issue. Why 'syscon-reboot' can be out of syscon-controller node, while 'syscon-reboot-mode' can't? They both belong to the same usecase: save cause id and reboot. So having similar properties-set and declaring their nodes someplace nearby is natural. According to the driver 'syscon-reboot' can't lack the regmap property because it's mandatory, while here you refuse to have even optional support. Additionally in most of the cases the 'syscon-reboot' nodes aren't declared as a child of a system controller node. Why 'syscon-reboot-mode' can't work in a similar way? Regards, -Sergey > > > > > Signed-off-by: Serge Semin > > Signed-off-by: Alexey Malahov > > Cc: Thomas Bogendoerfer > > Cc: Paul Burton > > Cc: Ralf Baechle > > --- > > .../bindings/power/reset/syscon-reboot-mode.yaml | 9 ++++++--- > > 1 file changed, 6 insertions(+), 3 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/power/reset/syscon-reboot-mode.yaml b/Documentation/devicetree/bindings/power/reset/syscon-reboot-mode.yaml > > index e09bb07b1abb..f47bf52ad983 100644 > > --- a/Documentation/devicetree/bindings/power/reset/syscon-reboot-mode.yaml > > +++ b/Documentation/devicetree/bindings/power/reset/syscon-reboot-mode.yaml > > @@ -13,9 +13,8 @@ description: | > > This driver gets reboot mode magic value from reboot-mode driver > > and stores it in a SYSCON mapped register. Then the bootloader > > can read it and take different action according to the magic > > - value stored. The SYSCON mapped register is retrieved from the > > - parental dt-node plus the offset. So the SYSCON reboot-mode node > > - should be represented as a sub-node of a "syscon", "simple-mfd" node. > > + value stored. The SYSCON mapped register is retrieved either from > > + the parental dt-node or from a regmap phandle plus the offset. > > > > properties: > > compatible: > > @@ -29,6 +28,10 @@ properties: > > $ref: /schemas/types.yaml#/definitions/uint32 > > description: Offset in the register map for the mode register (in bytes). > > > > + regmap: > > + $ref: /schemas/types.yaml#/definitions/phandle > > + description: Phandle to the register map node. > > + > > patternProperties: > > "^mode-.+": > > $ref: /schemas/types.yaml#/definitions/uint32 > > -- > > 2.25.1 > >