From: Douglas Anderson <dianders@chromium.org>
To: gregkh@linuxfoundation.org
Cc: mka@chromium.org, swboyd@chromium.org, ryandcase@chromium.org,
bjorn.andersson@linaro.org, akashast@codeaurora.org,
skakit@codeaurora.org, rojay@codeaurora.org,
mgautam@codeaurora.org, Douglas Anderson <dianders@chromium.org>,
Andy Gross <agross@kernel.org>,
Doug Anderson <dianders@google.com>,
Girish Mahadevan <girishm@codeaurora.org>,
Jiri Slaby <jslaby@suse.com>,
Karthikeyan Ramasubramanian <kramasub@codeaurora.org>,
Sagar Dharia <sdharia@codeaurora.org>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org
Subject: [PATCH 1/2] tty: serial: qcom_geni_serial: No need to stop tx/rx on UART shutdown
Date: Fri, 13 Mar 2020 13:46:51 -0700 [thread overview]
Message-ID: <20200313134635.1.Icf54c533065306b02b880c46dfd401d8db34e213@changeid> (raw)
On a board using qcom_geni_serial I found that I could no longer
interact with kdb if I got a crash after the "agetty" running on the
same serial port was killed. This meant that various classes of
crashes that happened at reboot time were undebuggable.
Reading through the code, I couldn't figure out why qcom_geni_serial
felt the need to run so much code at port shutdown time. All we need
to do is disable the interrupt.
After I make this change then a hardcoded kgdb_breakpoint in some late
shutdown code now allows me to interact with the debugger. I also
could freely close / re-open the port without problems.
Fixes: c4f528795d1a ("tty: serial: msm_geni_serial: Add serial driver support for GENI based QUP")
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---
drivers/tty/serial/qcom_geni_serial.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c
index 272bae0eebc7..09d8612517aa 100644
--- a/drivers/tty/serial/qcom_geni_serial.c
+++ b/drivers/tty/serial/qcom_geni_serial.c
@@ -827,17 +827,11 @@ static void get_tx_fifo_size(struct qcom_geni_serial_port *port)
static void qcom_geni_serial_shutdown(struct uart_port *uport)
{
- unsigned long flags;
-
/* Stop the console before stopping the current tx */
if (uart_console(uport))
console_stop(uport->cons);
disable_irq(uport->irq);
- spin_lock_irqsave(&uport->lock, flags);
- qcom_geni_serial_stop_tx(uport);
- qcom_geni_serial_stop_rx(uport);
- spin_unlock_irqrestore(&uport->lock, flags);
}
static int qcom_geni_serial_port_setup(struct uart_port *uport)
--
2.25.1.481.gfbce0eb801-goog
next reply other threads:[~2020-03-13 20:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-13 20:46 Douglas Anderson [this message]
2020-03-13 20:46 ` [PATCH 2/2] tty: serial: qcom_geni_serial: Don't try to manually disable the console Douglas Anderson
2020-03-16 17:57 ` Stephen Boyd
2020-03-17 13:07 ` Akash Asthana
2020-03-16 17:57 ` [PATCH 1/2] tty: serial: qcom_geni_serial: No need to stop tx/rx on UART shutdown Stephen Boyd
2020-03-17 13:05 ` Akash Asthana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200313134635.1.Icf54c533065306b02b880c46dfd401d8db34e213@changeid \
--to=dianders@chromium.org \
--cc=agross@kernel.org \
--cc=akashast@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=dianders@google.com \
--cc=girishm@codeaurora.org \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=kramasub@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mgautam@codeaurora.org \
--cc=mka@chromium.org \
--cc=rojay@codeaurora.org \
--cc=ryandcase@chromium.org \
--cc=sdharia@codeaurora.org \
--cc=skakit@codeaurora.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®