From: Jakub Kicinski <kuba@kernel.org>
To: Alexander Bersenev <bay@hackerdom.ru>
Cc: Oliver Neukum <oliver@neukum.org>,
"David S. Miller" <davem@davemloft.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Allison Randal <allison@lohutok.net>,
Enrico Weigelt <info@metux.net>,
Kate Stewart <kstewart@linuxfoundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-usb@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] cdc_ncm: Fix the build warning
Date: Fri, 13 Mar 2020 19:26:32 -0700 [thread overview]
Message-ID: <20200313192632.7900a288@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20200313213823.178435-2-bay@hackerdom.ru>
On Sat, 14 Mar 2020 02:38:21 +0500 Alexander Bersenev wrote:
> The ndp32->wLength is two bytes long, so replace cpu_to_le32 with cpu_to_le16.
missing signoff
> diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cdc_ncm.c
> index 5569077bd5b8..8929669b5e6d 100644
> --- a/drivers/net/usb/cdc_ncm.c
> +++ b/drivers/net/usb/cdc_ncm.c
> @@ -1172,7 +1172,7 @@ static struct usb_cdc_ncm_ndp32 *cdc_ncm_ndp32(struct cdc_ncm_ctx *ctx, struct s
> ndp32 = ctx->delayed_ndp32;
>
> ndp32->dwSignature = sign;
> - ndp32->wLength = cpu_to_le32(sizeof(struct usb_cdc_ncm_ndp32) + sizeof(struct usb_cdc_ncm_dpe32));
> + ndp32->wLength = cpu_to_le16(sizeof(struct usb_cdc_ncm_ndp32) + sizeof(struct usb_cdc_ncm_dpe32));
> return ndp32;
Isn't this code added in the previous patch? Why not squash them
together?
next prev parent reply other threads:[~2020-03-14 2:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-13 21:38 [PATCH 1/2] cdc_ncm: Implement the 32-bit version of NCM Transfer Block Alexander Bersenev
2020-03-13 21:38 ` [PATCH 2/2] cdc_ncm: Fix the build warning Alexander Bersenev
2020-03-14 2:26 ` Jakub Kicinski [this message]
2020-03-14 3:43 ` [PATCH 1/2] cdc_ncm: Implement the 32-bit version of NCM Transfer Block David Miller
2020-03-14 5:36 ` Александр Берсенев
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200313192632.7900a288@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=allison@lohutok.net \
--cc=bay@hackerdom.ru \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=info@metux.net \
--cc=kstewart@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oliver@neukum.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®