From: Guenter Roeck <linux@roeck-us.net>
To: Amy.Shih@advantech.com.tw
Cc: she90122@gmail.com, Jean Delvare <jdelvare@suse.com>,
linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
oakley.ding@advantech.com.tw, jia.sui@advantech.com.cn,
yuechao.zhao@advantech.com.cn
Subject: Re: [v1,1/1] Fix the incorrect quantity for fan & temp attributes.
Date: Sun, 15 Mar 2020 06:37:45 -0700 [thread overview]
Message-ID: <20200315133745.GA6049@roeck-us.net> (raw)
In-Reply-To: <20200312024934.3533-1-Amy.Shih@advantech.com.tw>
On Thu, Mar 12, 2020 at 02:49:34AM +0000, Amy.Shih@advantech.com.tw wrote:
> From: Amy Shih <amy.shih@advantech.com.tw>
>
> nct7904d supports 12 fan tachometers input and 13 temperatures
> (TEMP_CH1~4 and LTD + DTS TCPU1~8), fix the quantity for fan & temp
> attributes.
>
> Signed-off-by: Amy Shih <amy.shih@advantech.com.tw>
Applied.
Thanks,
Guenter
> ---
> drivers/hwmon/nct7904.c | 21 +++++++++++++++++++++
> 1 file changed, 21 insertions(+)
>
> diff --git a/drivers/hwmon/nct7904.c b/drivers/hwmon/nct7904.c
> index 281c81e..1f5743d 100644
> --- a/drivers/hwmon/nct7904.c
> +++ b/drivers/hwmon/nct7904.c
> @@ -7,6 +7,11 @@
> *
> * Copyright (c) 2019 Advantech
> * Author: Amy.Shih <amy.shih@advantech.com.tw>
> + *
> + * Supports the following chips:
> + *
> + * Chip #vin #fan #pwm #temp #dts chip ID
> + * nct7904d 20 12 4 5 8 0xc5
> */
>
> #include <linux/module.h>
> @@ -820,6 +825,10 @@ static int nct7904_detect(struct i2c_client *client,
> HWMON_F_INPUT | HWMON_F_MIN | HWMON_F_ALARM,
> HWMON_F_INPUT | HWMON_F_MIN | HWMON_F_ALARM,
> HWMON_F_INPUT | HWMON_F_MIN | HWMON_F_ALARM,
> + HWMON_F_INPUT | HWMON_F_MIN | HWMON_F_ALARM,
> + HWMON_F_INPUT | HWMON_F_MIN | HWMON_F_ALARM,
> + HWMON_F_INPUT | HWMON_F_MIN | HWMON_F_ALARM,
> + HWMON_F_INPUT | HWMON_F_MIN | HWMON_F_ALARM,
> HWMON_F_INPUT | HWMON_F_MIN | HWMON_F_ALARM),
> HWMON_CHANNEL_INFO(pwm,
> HWMON_PWM_INPUT | HWMON_PWM_ENABLE,
> @@ -853,6 +862,18 @@ static int nct7904_detect(struct i2c_client *client,
> HWMON_T_CRIT_HYST,
> HWMON_T_INPUT | HWMON_T_ALARM | HWMON_T_MAX |
> HWMON_T_MAX_HYST | HWMON_T_TYPE | HWMON_T_CRIT |
> + HWMON_T_CRIT_HYST,
> + HWMON_T_INPUT | HWMON_T_ALARM | HWMON_T_MAX |
> + HWMON_T_MAX_HYST | HWMON_T_TYPE | HWMON_T_CRIT |
> + HWMON_T_CRIT_HYST,
> + HWMON_T_INPUT | HWMON_T_ALARM | HWMON_T_MAX |
> + HWMON_T_MAX_HYST | HWMON_T_TYPE | HWMON_T_CRIT |
> + HWMON_T_CRIT_HYST,
> + HWMON_T_INPUT | HWMON_T_ALARM | HWMON_T_MAX |
> + HWMON_T_MAX_HYST | HWMON_T_TYPE | HWMON_T_CRIT |
> + HWMON_T_CRIT_HYST,
> + HWMON_T_INPUT | HWMON_T_ALARM | HWMON_T_MAX |
> + HWMON_T_MAX_HYST | HWMON_T_TYPE | HWMON_T_CRIT |
> HWMON_T_CRIT_HYST),
> NULL
> };
prev parent reply other threads:[~2020-03-15 13:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-12 2:49 Amy.Shih
2020-03-15 13:37 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200315133745.GA6049@roeck-us.net \
--to=linux@roeck-us.net \
--cc=Amy.Shih@advantech.com.tw \
--cc=jdelvare@suse.com \
--cc=jia.sui@advantech.com.cn \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oakley.ding@advantech.com.tw \
--cc=she90122@gmail.com \
--cc=yuechao.zhao@advantech.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome