From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CDF5C0044D for ; Mon, 16 Mar 2020 09:05:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 59AFC20658 for ; Mon, 16 Mar 2020 09:05:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730322AbgCPJFA (ORCPT ); Mon, 16 Mar 2020 05:05:00 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:41304 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730075AbgCPJE7 (ORCPT ); Mon, 16 Mar 2020 05:04:59 -0400 Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 2C50C146F7ECC; Mon, 16 Mar 2020 02:04:59 -0700 (PDT) Date: Mon, 16 Mar 2020 02:04:58 -0700 (PDT) Message-Id: <20200316.020458.1470957653235116686.davem@davemloft.net> To: mkubecek@suse.cz Cc: kuba@kernel.org, netdev@vger.kernel.org, johannes@sipsolutions.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH net 0/3] ethtool: fail with error if request has unknown flags From: David Miller In-Reply-To: References: X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 16 Mar 2020 02:04:59 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Michal Kubecek Date: Sun, 15 Mar 2020 18:17:38 +0100 (CET) > Jakub Kicinski pointed out that if unrecognized flags are set in netlink > header request, kernel shoud fail with an error rather than silently > ignore them so that we have more freedom in future flags semantics. > > To help userspace with handling such errors, inform the client which > flags are supported by kernel. For that purpose, we need to allow > passing cookies as part of extack also in case of error (they can be > only passed on success now). Series applied, thanks Michal.