From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 351E1C10F29 for ; Tue, 17 Mar 2020 06:42:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0D55E20674 for ; Tue, 17 Mar 2020 06:42:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725943AbgCQGl7 (ORCPT ); Tue, 17 Mar 2020 02:41:59 -0400 Received: from foss.arm.com ([217.140.110.172]:32872 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725536AbgCQGl7 (ORCPT ); Tue, 17 Mar 2020 02:41:59 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C89881FB; Mon, 16 Mar 2020 23:41:56 -0700 (PDT) Received: from e107533-lin.cambridge.arm.com (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A38003F52E; Mon, 16 Mar 2020 23:45:55 -0700 (PDT) Date: Tue, 17 Mar 2020 06:41:52 +0000 From: Sudeep Holla To: Jeffy Chen Cc: linux-kernel@vger.kernel.org, anders.roxell@linaro.org, arnd@arndb.de, sboyd@kernel.org, gregkh@linuxfoundation.org, naresh.kamboju@linaro.org, daniel.lezcano@linaro.org, Basil.Eljuse@arm.com, mturquette@baylibre.com, Sudeep Holla , "Rafael J. Wysocki" Subject: Re: [PATCH v2] arch_topology: Fix putting invalid cpu clk Message-ID: <20200317064152.GB12791@e107533-lin.cambridge.arm.com> References: <20200317063308.23209-1-jeffy.chen@rock-chips.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200317063308.23209-1-jeffy.chen@rock-chips.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 17, 2020 at 02:33:08PM +0800, Jeffy Chen wrote: > Add a sanity check before putting the cpu clk. > > Fixes: b8fe128dad8f (“arch_topology: Adjust initial CPU capacities with current freq") Interesting, I had NACKed the original patch in v1 IIRC. I was against for adding clk into arch topology as not all platform control CPUFreq via clk APIs. Anyways, as fix this makes sense, but I need to take a look and find ways to remove it if possible, but that's for some other time. -- Regards, Sudeep