From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF070C2BB1D for ; Tue, 17 Mar 2020 08:03:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A580E20674 for ; Tue, 17 Mar 2020 08:03:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="uaNAUErh" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726112AbgCQIDp (ORCPT ); Tue, 17 Mar 2020 04:03:45 -0400 Received: from mail-pj1-f67.google.com ([209.85.216.67]:56203 "EHLO mail-pj1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725794AbgCQIDp (ORCPT ); Tue, 17 Mar 2020 04:03:45 -0400 Received: by mail-pj1-f67.google.com with SMTP id mj6so9631680pjb.5 for ; Tue, 17 Mar 2020 01:03:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=wJzj+NhO+lX1yEtnXWO3HvgiRxvAHYyMwldXylz/g50=; b=uaNAUErhn8Wd3uexgimEazU8oaz2CrrpINTw3zlsRrv70YFqLvop1Mm4dr5cHY2TQ+ tlguxrHlr1t/Tf56J59gXfrDqU5q9OIq9C36XMKu6hosdc97qIwiKaEtHCX8r3eitpRw 6nolpgswSdHtVLtNa8s2ZTGzXh8VLzxbaO1YF/y1LwNmupkZSALAA9mwcIULIpaneNn1 Hvv83kSpGXCFlzl1aWtp8CLaeWqU1oF8cjKFmz0w7kHptEP7AL4uY7HS+7v6K1AoLD7m hZaTc8HFgSVpBeOI2GtB+TXNiUZzc3bz5jk7aIlhIvGStQdBiGJukG8s/BGUbsL/VR70 OZng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=wJzj+NhO+lX1yEtnXWO3HvgiRxvAHYyMwldXylz/g50=; b=ArL/d7q12DKn1vzph5HCu7sH3FtMElr9WB4rW3YFoRD9HsVLTsFRQ1/da+Ieu7hl3d Yfewcunezz1ix4oZO/pjoT9/GpxqifnESjsc+jhZgCRtLbnEzX+bPb/WzyXljw2dpZVJ WmzGVhC7VqIh9v42+Ey4GYs55/e9Mt2uwmVHMSfPbsiR0nPRLCp38bOqGs8ppYeXMgAB yFeOILoNJ63/7UKcib7qkcRHeKrgzyMtMoOFDppA5G22FZE7sVjIpEd7g5kohUgYtQhS viTOWAK3iRwRh1sKyzInBzVfAAhcidrH2mbdhTfdvO36btW5d6CEmqvpEmKJEYKH9jDO vr5Q== X-Gm-Message-State: ANhLgQ0dkzfYsT41XCpT23swCJ+ur0EG2ZbR+qXZL8s2qHiu8Qe0KWN7 ElRqOWiFcShzONT/sZfXypzj9Q== X-Google-Smtp-Source: ADFU+vsA93AKpo6rZVnei/jHWtpv1Oy0bklJm2y9V7JgrzPTTmeqgzvFd+SAx1MK0x6Lnj2Ha34y2w== X-Received: by 2002:a17:902:9a45:: with SMTP id x5mr3005594plv.296.1584432223464; Tue, 17 Mar 2020 01:03:43 -0700 (PDT) Received: from localhost ([122.171.122.128]) by smtp.gmail.com with ESMTPSA id j19sm2106447pfe.102.2020.03.17.01.03.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 17 Mar 2020 01:03:42 -0700 (PDT) Date: Tue, 17 Mar 2020 13:33:40 +0530 From: Viresh Kumar To: Anson Huang Cc: rjw@rjwysocki.net, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Linux-imx@nxp.com Subject: Re: [PATCH] cpufreq: imx6q-cpufreq: Improve the logic of -EPROBE_DEFER handling Message-ID: <20200317080340.475xamakfosykrro@vireshk-i7> References: <1584419934-2303-1-git-send-email-Anson.Huang@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1584419934-2303-1-git-send-email-Anson.Huang@nxp.com> User-Agent: NeoMutt/20180716-391-311a52 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17-03-20, 12:38, Anson Huang wrote: > Improve the -EPROBE_DEFER handling logic to simplify the code. > > Signed-off-by: Anson Huang > --- > drivers/cpufreq/imx6q-cpufreq.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/drivers/cpufreq/imx6q-cpufreq.c b/drivers/cpufreq/imx6q-cpufreq.c > index 285b8e9..fdb2fff 100644 > --- a/drivers/cpufreq/imx6q-cpufreq.c > +++ b/drivers/cpufreq/imx6q-cpufreq.c > @@ -400,11 +400,9 @@ static int imx6q_cpufreq_probe(struct platform_device *pdev) > ret = imx6q_opp_check_speed_grading(cpu_dev); > } > if (ret) { > - if (ret == -EPROBE_DEFER) > - goto out_free_opp; > - > - dev_err(cpu_dev, "failed to read ocotp: %d\n", > - ret); > + if (ret != -EPROBE_DEFER) > + dev_err(cpu_dev, "failed to read ocotp: %d\n", > + ret); > goto out_free_opp; > } Applied. Thanks. -- viresh