From: Andrew Lunn <andrew@lunn.ch>
To: Chris Packham <chris.packham@alliedtelesis.co.nz>
Cc: davem@davemloft.net, josua@solid-run.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] Revert "net: mvmdio: avoid error message for optional IRQ"
Date: Tue, 17 Mar 2020 15:25:15 +0100 [thread overview]
Message-ID: <20200317142515.GV24270@lunn.ch> (raw)
In-Reply-To: <20200316074907.21879-2-chris.packham@alliedtelesis.co.nz>
On Mon, Mar 16, 2020 at 08:49:06PM +1300, Chris Packham wrote:
> This reverts commit e1f550dc44a4d535da4e25ada1b0eaf8f3417929.
> platform_get_irq_optional() will still return -ENXIO when no interrupt
> is provided so the additional error handling caused the driver prone to
> fail when no interrupt was specified. Revert the change so we can apply
> the correct minimal fix.
>
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2020-03-17 14:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-16 7:49 [PATCH v3 0/2] net: mvmdio: avoid error message for optional IRQ Chris Packham
2020-03-16 7:49 ` [PATCH v3 1/2] Revert "net: mvmdio: avoid error message for optional IRQ" Chris Packham
2020-03-17 14:25 ` Andrew Lunn [this message]
2020-03-16 7:49 ` [PATCH v3 2/2] net: mvmdio: avoid error message for optional IRQ Chris Packham
2020-03-17 14:24 ` [PATCH v3 0/2] " Andrew Lunn
2020-03-18 3:54 ` David Miller
2020-04-08 1:19 ` Matteo Croce
2020-04-08 1:44 ` Chris Packham
2020-04-10 13:46 ` Matteo Croce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200317142515.GV24270@lunn.ch \
--to=andrew@lunn.ch \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=davem@davemloft.net \
--cc=josua@solid-run.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®