From: Masami Hiramatsu <mhiramat@kernel.org>
To: Adriana Kobylak <anoo@linux.ibm.com>,
Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org, anoo@us.ibm.com
Subject: Re: [PATCH] tools/bootconfig: Makefile: Create destination directory
Date: Tue, 17 Mar 2020 22:15:16 +0900 [thread overview]
Message-ID: <20200317221516.25d92373a0194c9237b1ee38@kernel.org> (raw)
In-Reply-To: <1584373766-3509-1-git-send-email-anoo@linux.ibm.com>
On Mon, 16 Mar 2020 10:49:26 -0500
Adriana Kobylak <anoo@linux.ibm.com> wrote:
> From: Adriana Kobylak <anoo@us.ibm.com>
>
> The DESTDIR path may not be available to the caller, such as
> compiling the bootconfig tool from a Yocto native recipe. Have
> the Makefile create the directory instead.
OK, this looks good to me.
Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
Thanks!
>
> Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
> ---
> tools/bootconfig/Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/bootconfig/Makefile b/tools/bootconfig/Makefile
> index a6146ac..470b6f0 100644
> --- a/tools/bootconfig/Makefile
> +++ b/tools/bootconfig/Makefile
> @@ -14,6 +14,7 @@ bootconfig: ../../lib/bootconfig.c main.c $(HEADER)
> $(CC) $(filter %.c,$^) $(CFLAGS) -o $@
>
> install: $(PROGS)
> + install -d $(DESTDIR)$(bindir)
> install bootconfig $(DESTDIR)$(bindir)
>
> test: bootconfig
> --
> 1.8.3.1
>
--
Masami Hiramatsu <mhiramat@kernel.org>
prev parent reply other threads:[~2020-03-17 13:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-16 15:49 Adriana Kobylak
2020-03-17 13:15 ` Masami Hiramatsu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200317221516.25d92373a0194c9237b1ee38@kernel.org \
--to=mhiramat@kernel.org \
--cc=anoo@linux.ibm.com \
--cc=anoo@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®