From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52837C1975A for ; Tue, 17 Mar 2020 22:27:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 13CEB20752 for ; Tue, 17 Mar 2020 22:27:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584484023; bh=feXoVNdYfrV4TFKhykYHVASYD8nshaCB8LWcN1l/eP0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=vZlNotyskVQwdCF40aHnv+q8k6SykQHia0Dr3X+BqiMujjAAUFxH4YHheLjLtr3I+ 9uNHbEu4lgrRL/B1iZSNchG6mP6CYAMm+fwmu4WSyr5VfOdRBWbKYBvOQWFneHIfAO VoEEMVw0rQMQGXgyxs7CfELBrZyvJVvQiJB1avXQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727183AbgCQW1C (ORCPT ); Tue, 17 Mar 2020 18:27:02 -0400 Received: from mail.kernel.org ([198.145.29.99]:36408 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726530AbgCQW1B (ORCPT ); Tue, 17 Mar 2020 18:27:01 -0400 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9F310206EC; Tue, 17 Mar 2020 22:26:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584484021; bh=feXoVNdYfrV4TFKhykYHVASYD8nshaCB8LWcN1l/eP0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OuSZmRfjKjT3bppoNPLTNL8hxyiP67j2pV1bJszZfFXsz6kepBPj0ffTfi3CAMdhX PT18tvPVppBBRLf9c8jRrZiCyLQShrtjUtDVfD3YSbrLvSbOX73h0e1ecdX6fk7g8Q jLcEb8O5V34blCKFSXRQG03gPImfHhSwjEX+lfPM= Date: Tue, 17 Mar 2020 22:26:56 +0000 From: Will Deacon To: =?iso-8859-1?Q?R=E9mi?= Denis-Courmont Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, maz@kernel.org, james.morse@arm.com, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com, kvmarm@lists.cs.columbia.edu, catalin.marinas@arm.com Subject: Re: [PATCH] arm64: move kimage_vaddr to .rodata Message-ID: <20200317222656.GE20788@willie-the-truck> References: <20200312094002.153302-1-remi@remlab.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200312094002.153302-1-remi@remlab.net> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 12, 2020 at 11:40:02AM +0200, Rémi Denis-Courmont wrote: > From: Remi Denis-Courmont > > This datum is not referenced from .idmap.text: it does not need to be > mapped in idmap. Lets move it to .rodata as it is never written to after > early boot of the primary CPU. > (Maybe .data.ro_after_init would be cleaner though?) > > Signed-off-by: Rémi Denis-Courmont > --- > arch/arm64/kernel/head.S | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-) > > diff --git a/arch/arm64/kernel/head.S b/arch/arm64/kernel/head.S > index 6e08ee2b4d55..8e5c0e0040e4 100644 > --- a/arch/arm64/kernel/head.S > +++ b/arch/arm64/kernel/head.S > @@ -457,17 +457,19 @@ SYM_FUNC_START_LOCAL(__primary_switched) > b start_kernel > SYM_FUNC_END(__primary_switched) > > + .pushsection ".rodata", "a" > +SYM_DATA_START(kimage_vaddr) > + .quad _text - TEXT_OFFSET > +SYM_DATA_END(kimage_vaddr) > +EXPORT_SYMBOL(kimage_vaddr) > + .popsection > + > /* > * end early head section, begin head code that is also used for > * hotplug and needs to have the same protections as the text region > */ > .section ".idmap.text","awx" > > -SYM_DATA_START(kimage_vaddr) > - .quad _text - TEXT_OFFSET > -SYM_DATA_END(kimage_vaddr) > -EXPORT_SYMBOL(kimage_vaddr) Acked-by: Will Deacon Will