From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: "吳昊澄 Ricky" <ricky_wu@realtek.com>,
"Arnd Bergmann" <arnd@arndb.de>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mmc: rtsx: Fixed TX/RX register and optimized TX parameter
Date: Wed, 18 Mar 2020 11:43:21 +0100 [thread overview]
Message-ID: <20200318104321.GA2303953@kroah.com> (raw)
In-Reply-To: <CAPDyKFqfNp0uo6oY2ZkYVYknkYiyovtU2Ss4+y39AnuRi4nWVQ@mail.gmail.com>
On Tue, Mar 17, 2020 at 12:58:35PM +0100, Ulf Hansson wrote:
> On Tue, 17 Mar 2020 at 03:45, 吳昊澄 Ricky <ricky_wu@realtek.com> wrote:
> >
> >
> > > -----Original Message-----
> > > From: Ulf Hansson [mailto:ulf.hansson@linaro.org]
> > > Sent: Monday, March 16, 2020 10:17 PM
> > > To: 吳昊澄 Ricky
> > > Cc: linux-mmc@vger.kernel.org; Linux Kernel Mailing List; Arnd Bergmann; Greg
> > > Kroah-Hartman
> > > Subject: Re: [PATCH] mmc: rtsx: Fixed TX/RX register and optimized TX
> > > parameter
> > >
> > > On Mon, 16 Mar 2020 at 03:52, <ricky_wu@realtek.com> wrote:
> > > >
> > > > From: Ricky Wu <ricky_wu@realtek.com>
> > > >
> > > > Fixed sd_change_phase TX/RX register
> > > > Optimized rts522a rts524a rts525a rts5260 rts5261 TX initial parameter
> > >
> > > I don't understand what this actually fixes. Can you try to elaborate
> > > a bit on this, please?
> > >
> > > Do you think this is needed for stable, then why?
> >
> > Yes, I think it need patch to stable
> >
> > In function sd_change_phase() whether it is TX or RX always write the same register(TX), so patch this function make RX and TX can change well.
> > At mmc stack mechanism do not tuning TX phase, so need give a stable parameter for TX phase(sdr104 sdr50 ddr50) at initial.
>
> Alright, I took the liberty to clarify the changelog a bit according
> to this. Please have a look at my fixes branch and tell me if I should
> do some additional changes of the changelog.
>
> Applied for fixes and by adding a stable tag, thanks!
>
> Arnd, Greg, so I am picking this via my mmc tree, please shout at me
> (or ack it) if you have any concerns with this. :-)
No concerns at all!
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
prev parent reply other threads:[~2020-03-18 10:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-16 2:52 ricky_wu
2020-03-16 14:16 ` Ulf Hansson
2020-03-17 2:45 ` 吳昊澄 Ricky
2020-03-17 11:58 ` Ulf Hansson
2020-03-18 10:43 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200318104321.GA2303953@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ricky_wu@realtek.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome