From: Mark Brown <broonie@kernel.org>
To: Will Deacon <will@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
Hongbo Yao <yaohongbo@huawei.com>,
linux-kernel@vger.kernel.org, catalin.marinas@arm.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC PATCH] arm64: fix the missing ktpi= cmdline check in arm64_kernel_unmapped_at_el0()
Date: Wed, 18 Mar 2020 11:32:17 +0000 [thread overview]
Message-ID: <20200318113217.GA4553@sirena.org.uk> (raw)
In-Reply-To: <20200317210154.GA19752@willie-the-truck>
[-- Attachment #1: Type: text/plain, Size: 886 bytes --]
On Tue, Mar 17, 2020 at 09:01:54PM +0000, Will Deacon wrote:
> On Tue, Mar 17, 2020 at 04:36:38PM +0000, Mark Brown wrote:
> > I'd need to go back and retest to confirm but it looks like always had
> > the issue that we'd install some nG mappings early even with KPTI
> > disabled on the command line so your change is just restoring the
> > previous behaviour and we're no worse than we were before.
> Urgh, this code brings back really bad memories :( :( :(
Tell me about it.
> So I've hacked the following, which appears to work but damn I'd like
> somebody else to look at this. I also have a nagging feeling that you
> implemented it like this at some point, but we tried to consolidate things
> during review.
> Thoughts?
I don't think I did *exactly* this but it's familiar yeah. It looks
sensible and I can't think of any problems but that doesn't mean there
aren't any.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-03-18 11:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-17 11:47 Hongbo Yao
2020-03-17 12:10 ` Mark Rutland
2020-03-17 12:43 ` Will Deacon
2020-03-17 13:57 ` Mark Brown
2020-03-17 15:18 ` Will Deacon
2020-03-17 16:36 ` Mark Brown
2020-03-17 21:01 ` Will Deacon
2020-03-18 11:32 ` Mark Brown [this message]
2020-03-18 20:13 ` Will Deacon
2020-03-19 6:14 ` Hongbo Yao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200318113217.GA4553@sirena.org.uk \
--to=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=will@kernel.org \
--cc=yaohongbo@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®