From: Vijay Thakkar <vijaythakkar@me.com>
To: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
Cc: "Peter Zijlstra" <peterz@infradead.org>,
"Ingo Molnar" <mingo@redhat.com>,
"Kim Phillips" <kim.phillips@amd.com>,
"Alexander Shishkin" <alexander.shishkin@linux.intel.com>,
"Jiri Olsa" <jolsa@redhat.com>,
"Namhyung Kim" <namhyung@kernel.org>,
"Martin Liška" <mliska@suse.cz>, "Jon Grimm" <jon.grimm@amd.com>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v5 2/3] perf vendor events amd: add Zen2 events
Date: Wed, 18 Mar 2020 11:21:12 -0400 [thread overview]
Message-ID: <20200318152112.GA231037@shwetrath.localdomain> (raw)
In-Reply-To: <20200318142057.GD11531@kernel.org>
> floating point:
> fpu_pipe_assignment.total
> [Total number of fp uOps]
>
>
> Metric Groups:
>
I just realized that I did not add back the counters for per pipe total
assignment as I said in the commit message. Patch 3/3 adds the total
uOp assignments per pipe for Zen1 based processors. Although the PPR for
Matisse does not list these counters, I can still sample them on my
Ryzen 3900X system and they seem to report correct numbers. For example,
here is the result of running:
$> perf stat -e r100,r200,r400,r800,rf00 ls
$> Performance counter stats for 'ls':
5,047 r100:u
5,236 r200:u
31,300 r400:u
2,040 r800:u
43,623 fpu_pipe_assignment.total:u
Note that the per pipe total counters add up the overall total, which
makes me think I should submit a v6 of this patch adding the per pipe
totals for zen2 as well, especially since it is mentioned in the commit
message.
-Vijay
next prev parent reply other threads:[~2020-03-18 15:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-16 22:52 [PATCH v5 0/3] Vijay Thakkar
2020-03-16 22:52 ` [PATCH v5 1/3] perf vendor events amd: restrict model detection for zen1 based processors Vijay Thakkar
2020-03-16 23:59 ` Kim Phillips
2020-03-16 22:52 ` [PATCH v5 2/3] perf vendor events amd: add Zen2 events Vijay Thakkar
2020-03-18 14:20 ` Arnaldo Carvalho de Melo
2020-03-18 15:21 ` Vijay Thakkar [this message]
2020-03-18 15:52 ` Arnaldo Carvalho de Melo
2020-03-18 19:07 ` Vijay Thakkar
2020-03-16 22:52 ` [PATCH v5 3/3] perf vendor events amd: update Zen1 events to V2 Vijay Thakkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200318152112.GA231037@shwetrath.localdomain \
--to=vijaythakkar@me.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=arnaldo.melo@gmail.com \
--cc=jolsa@redhat.com \
--cc=jon.grimm@amd.com \
--cc=kim.phillips@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mliska@suse.cz \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®