From: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Jin Yao <yao.jin@linux.intel.com>,
jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com,
alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org,
ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com
Subject: Re: [PATCH] perf stat: Align the output for interval aggregation mode
Date: Wed, 18 Mar 2020 16:00:49 -0300 [thread overview]
Message-ID: <20200318190049.GM11531@kernel.org> (raw)
In-Reply-To: <20200220105355.GA553812@krava>
Em Thu, Feb 20, 2020 at 11:53:55AM +0100, Jiri Olsa escreveu:
> On Tue, Feb 18, 2020 at 03:16:14PM +0800, Jin Yao wrote:
> > There is a slight misalignment in -A -I output.
> >
> > For example,
> >
> > perf stat -e cpu/event=cpu-cycles/ -a -A -I 1000
> >
> > # time CPU counts unit events
> > 1.000440863 CPU0 1,068,388 cpu/event=cpu-cycles/
> > 1.000440863 CPU1 875,954 cpu/event=cpu-cycles/
> > 1.000440863 CPU2 3,072,538 cpu/event=cpu-cycles/
> > 1.000440863 CPU3 4,026,870 cpu/event=cpu-cycles/
> > 1.000440863 CPU4 5,919,630 cpu/event=cpu-cycles/
> > 1.000440863 CPU5 2,714,260 cpu/event=cpu-cycles/
> > 1.000440863 CPU6 2,219,240 cpu/event=cpu-cycles/
> > 1.000440863 CPU7 1,299,232 cpu/event=cpu-cycles/
> >
> > The value of counts is not aligned with the column "counts" and
> > the event name is not aligned with the column "events".
> >
> > With this patch, the output is,
> >
> > perf stat -e cpu/event=cpu-cycles/ -a -A -I 1000
> >
> > # time CPU counts unit events
> > 1.000423009 CPU0 997,421 cpu/event=cpu-cycles/
> > 1.000423009 CPU1 1,422,042 cpu/event=cpu-cycles/
> > 1.000423009 CPU2 484,651 cpu/event=cpu-cycles/
> > 1.000423009 CPU3 525,791 cpu/event=cpu-cycles/
> > 1.000423009 CPU4 1,370,100 cpu/event=cpu-cycles/
> > 1.000423009 CPU5 442,072 cpu/event=cpu-cycles/
> > 1.000423009 CPU6 205,643 cpu/event=cpu-cycles/
> > 1.000423009 CPU7 1,302,250 cpu/event=cpu-cycles/
> >
> > Now output is aligned.
> >
> > Signed-off-by: Jin Yao <yao.jin@linux.intel.com>
>
> Acked-by: Jiri Olsa <jolsa@redhat.com>
thanks, tested and applied.
- Arnaldo
next prev parent reply other threads:[~2020-03-18 19:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-18 7:16 Jin Yao
2020-02-20 10:53 ` Jiri Olsa
2020-03-18 19:00 ` Arnaldo Carvalho de Melo [this message]
2020-04-04 8:42 ` [tip: perf/urgent] " tip-bot2 for Jin Yao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200318190049.GM11531@kernel.org \
--to=arnaldo.melo@gmail.com \
--cc=Linux-kernel@vger.kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=kan.liang@intel.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=yao.jin@intel.com \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome