From: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
To: Jin Yao <yao.jin@linux.intel.com>
Cc: jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com,
alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org,
ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com
Subject: Re: [PATCH v7 0/3] perf report: Support sorting by a given event in group
Date: Wed, 18 Mar 2020 16:08:32 -0300 [thread overview]
Message-ID: <20200318190832.GP11531@kernel.org> (raw)
In-Reply-To: <20200318190325.GO11531@kernel.org>
Em Wed, Mar 18, 2020 at 04:03:25PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Wed, Mar 18, 2020 at 04:01:16PM -0300, Arnaldo Carvalho de Melo escreveu:
> > Em Thu, Feb 20, 2020 at 09:36:13AM +0800, Jin Yao escreveu:
> > > When performing "perf report --group", it shows the event group information
> > > together. By default, the output is sorted by the first event in group.
> > > It would be nice for user to select any event for sorting.
> > >
> > > The patch 1/3 introduces a new option "--group-sort-idx" to sort the
> > > output by the event at the index n in event group.
> > >
> > > The patch 2/3 creates a new key K_RELOAD to reload the browser.
> > >
> > > The patch 3/3 supports hotkeys in browser to select a event to
> > > sort.
> >
> > Thanks, applied.
>
> Doesn't work with 'perf top', should, investigating,
So needs a bit of work, but is doable and would be a great addition,
since we do support:
# perf top --group -e instructions,cycles,cache-misses
And we should strive to make 'perf top' to be a perf.data-less, dynamic
version of 'perf record + perf report'.
Can you please take a look at supporting this? And that --group-sort-idx
too,
I'll push my perf/core branch after a few tests,
Thanks,
- Arnaldo
next prev parent reply other threads:[~2020-03-18 19:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-20 1:36 Jin Yao
2020-02-20 1:36 ` [PATCH v7 1/3] perf report: Change sort order by a specified " Jin Yao
2020-03-18 18:45 ` Arnaldo Carvalho de Melo
2020-03-19 1:14 ` Jin, Yao
2020-04-04 8:42 ` [tip: perf/urgent] perf report: Allow specifying event to be used as sort key in --group output tip-bot2 for Jin Yao
2020-02-20 1:36 ` [PATCH v7 2/3] perf report: Support a new key to reload the browser Jin Yao
2020-03-18 18:52 ` Arnaldo Carvalho de Melo
2020-03-19 1:40 ` Jin, Yao
2020-04-04 8:42 ` [tip: perf/urgent] " tip-bot2 for Jin Yao
2020-02-20 1:36 ` [PATCH v7 3/3] perf report: support hotkey to let user select any event for sorting Jin Yao
2020-04-04 8:42 ` [tip: perf/urgent] perf report/top TUI: Support hotkeys " tip-bot2 for Jin Yao
2020-03-18 19:01 ` [PATCH v7 0/3] perf report: Support sorting by a given event in group Arnaldo Carvalho de Melo
2020-03-18 19:03 ` Arnaldo Carvalho de Melo
2020-03-18 19:08 ` Arnaldo Carvalho de Melo [this message]
2020-03-19 1:42 ` Jin, Yao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200318190832.GP11531@kernel.org \
--to=arnaldo.melo@gmail.com \
--cc=Linux-kernel@vger.kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@intel.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=yao.jin@intel.com \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome