From: Christoph Hellwig <hch@infradead.org>
To: light.hsieh@mediatek.com
Cc: ulf.hansson@linaro.org, linux-mediatek@lists.infradead.org,
axboe@kernel.dk, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, kuohong.wang@mediatek.com,
stanley.chu@mediatek.com
Subject: Re: [PATCH v1 3/3] block: set partition read/write policy according to write-protection status
Date: Thu, 19 Mar 2020 03:25:36 -0700 [thread overview]
Message-ID: <20200319102536.GA16757@infradead.org> (raw)
In-Reply-To: <1583290274-5525-4-git-send-email-light.hsieh@mediatek.com>
On Wed, Mar 04, 2020 at 10:51:14AM +0800, light.hsieh@mediatek.com wrote:
> From: Light Hsieh <light.hsieh@mediatek.com>
>
> For storage device with write-protection support, e.g. eMMC, register
> check_disk_range_wp() in struct block_device_operations for checking
> write-protection status. When creating block device for a partition, set
> read/write policy according to result of check_disk_range_wp() operation
> (if registered).
>
> Without this patch, ro attribute is not set for created block device of
> write-protected partition. User perform asynchronous buffered write to
> such partition won't get immediate error and therefore he won't be awared
> that write is not actually performed.
> With this patch, ro attribute is set for created block device of
> write-protected partition. User perform asynchronous buffered write to
> such partition will get immediate error and therefore he will be awared.
NAK. This is complete BS. Partitions are a complete software concepts
and idiotic features like a range read only should not interact with it
at all (and I urge all Linux users to never make use of such broken
features, so the less support we have for them, the better).
next prev parent reply other threads:[~2020-03-19 10:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-04 2:51 [PATCH v1 0/3] set ro attribute of block device " light.hsieh
2020-03-04 2:51 ` [PATCH v1 1/3] mmc: record wp_grp_size and boot_wp_status light.hsieh
2020-03-04 2:51 ` [PATCH v1 2/3] mmc: check write-protection status during BLKROSET ioctl light.hsieh
2020-03-04 2:51 ` [PATCH v1 3/3] block: set partition read/write policy according to write-protection status light.hsieh
2020-03-19 10:25 ` Christoph Hellwig [this message]
2020-03-04 2:57 [PATCH v1 0/3] set ro attribute of block device " light.hsieh
2020-03-04 2:57 ` [PATCH v1 3/3] block: set partition read/write policy " light.hsieh
2020-03-04 3:01 [PATCH v1 0/3] set ro attribute of block device " light.hsieh
2020-03-04 3:01 ` [PATCH v1 3/3] block: set partition read/write policy " light.hsieh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200319102536.GA16757@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=kuohong.wang@mediatek.com \
--cc=light.hsieh@mediatek.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=stanley.chu@mediatek.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®