From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56FD7C4332E for ; Sun, 22 Mar 2020 03:10:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2A93720724 for ; Sun, 22 Mar 2020 03:10:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728345AbgCVDK0 (ORCPT ); Sat, 21 Mar 2020 23:10:26 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:34390 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727296AbgCVDKZ (ORCPT ); Sat, 21 Mar 2020 23:10:25 -0400 Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 4546215AC1030; Sat, 21 Mar 2020 20:10:24 -0700 (PDT) Date: Sat, 21 Mar 2020 20:10:22 -0700 (PDT) Message-Id: <20200321.201022.719210614219273669.davem@davemloft.net> To: grygorii.strashko@ti.com Cc: andrew@lunn.ch, f.fainelli@gmail.com, dmurphy@ti.com, hkallweit1@gmail.com, netdev@vger.kernel.org, nsekhar@ti.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: phy: dp83867: w/a for fld detect threshold bootstrapping issue From: David Miller In-Reply-To: <20200317180454.22393-1-grygorii.strashko@ti.com> References: <20200317180454.22393-1-grygorii.strashko@ti.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 21 Mar 2020 20:10:25 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Grygorii Strashko Date: Tue, 17 Mar 2020 20:04:54 +0200 > When the DP83867 PHY is strapped to enable Fast Link Drop (FLD) feature > STRAP_STS2.STRAP_ FLD (reg 0x006F bit 10), the Energy Lost Threshold for > FLD Energy Lost Mode FLD_THR_CFG.ENERGY_LOST_FLD_THR (reg 0x002e bits 2:0) > will be defaulted to 0x2. This may cause the phy link to be unstable. The > new DP83867 DM recommends to always restore ENERGY_LOST_FLD_THR to 0x1. > > Hence, restore default value of FLD_THR_CFG.ENERGY_LOST_FLD_THR to 0x1 when > FLD is enabled by bootstrapping as recommended by DM. > > Signed-off-by: Grygorii Strashko Applied, thank you. Let me know if I should queue this up for -stable.