From: Michal Kubecek <mkubecek@suse.cz>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] ethtool: fix reference leak in some *_SET handlers
Date: Sun, 22 Mar 2020 21:51:09 +0100 [thread overview]
Message-ID: <20200322205109.GF31519@unicorn.suse.cz> (raw)
In-Reply-To: <20200322134356.55f7d9b8@kicinski-fedora-PC1C0HJN>
On Sun, Mar 22, 2020 at 01:43:56PM -0700, Jakub Kicinski wrote:
> On Sun, 22 Mar 2020 21:15:51 +0100 (CET) Michal Kubecek wrote:
> > Andrew noticed that some handlers for *_SET commands leak a netdev
> > reference if required ethtool_ops callbacks do not exist. A simple
> > reproducer would be e.g.
> >
> > ip link add veth1 type veth peer name veth2
> > ethtool -s veth1 wol g
> > ip link del veth1
> >
> > Make sure dev_put() is called when ethtool_ops check fails.
>
> Fixes: e54d04e3afea ("ethtool: set message mask with DEBUG_SET request")
> Fixes: a53f3d41e4d3 ("ethtool: set link settings with LINKINFO_SET request")
> Fixes: bfbcfe2032e7 ("ethtool: set link modes related data with LINKMODES_SET request")
> Fixes: 8d425b19b305 ("ethtool: set wake-on-lan settings with WOL_SET request")
Yes, thank you, I forgot about Fixes tags.
Should I resubmit or will patchworks pick the tags from your reply?
Michal
> > Reported-by: Andrew Lunn <andrew@lunn.ch>
> > Signed-off-by: Michal Kubecek <mkubecek@suse.cz>
>
> Reviewed-by: Jakub Kicinski <kuba@kernel.org>
next prev parent reply other threads:[~2020-03-22 20:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-22 20:15 Michal Kubecek
2020-03-22 20:23 ` Andrew Lunn
2020-03-22 20:42 ` Florian Fainelli
2020-03-22 20:43 ` Jakub Kicinski
2020-03-22 20:51 ` Michal Kubecek [this message]
2020-03-22 21:06 ` Jakub Kicinski
2020-03-22 21:25 ` Michal Kubecek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200322205109.GF31519@unicorn.suse.cz \
--to=mkubecek@suse.cz \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®