From: David Miller <davem@davemloft.net>
To: natechancellor@gmail.com
Cc: jiri@mellanox.com, idosch@mellanox.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mlxsw: spectrum_cnt: Fix 64-bit division in mlxsw_sp_counter_resources_register
Date: Mon, 23 Mar 2020 20:57:44 -0700 (PDT) [thread overview]
Message-ID: <20200323.205744.1206748041598234398.davem@davemloft.net> (raw)
In-Reply-To: <20200320021638.1916-1-natechancellor@gmail.com>
From: Nathan Chancellor <natechancellor@gmail.com>
Date: Thu, 19 Mar 2020 19:16:38 -0700
> When building arm32 allyesconfig:
>
> ld.lld: error: undefined symbol: __aeabi_uldivmod
>>>> referenced by spectrum_cnt.c
>>>> net/ethernet/mellanox/mlxsw/spectrum_cnt.o:(mlxsw_sp_counter_resources_register) in archive drivers/built-in.a
>>>> did you mean: __aeabi_uidivmod
>>>> defined in: arch/arm/lib/lib.a(lib1funcs.o)
>
> pool_size and bank_size are u64; use div64_u64 so that 32-bit platforms
> do not error.
>
> Fixes: ab8c4cc60420 ("mlxsw: spectrum_cnt: Move config validation along with resource register")
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Applied to net-next.
Please be clear about the intended target GIT tree for your changes in the
Subject line in the future, thank you.
prev parent reply other threads:[~2020-03-24 3:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-20 2:16 Nathan Chancellor
2020-03-20 9:55 ` Jiri Pirko
2020-03-24 3:57 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200323.205744.1206748041598234398.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=idosch@mellanox.com \
--cc=jiri@mellanox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=natechancellor@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®