mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dejin Zheng <zhengdejin5@gmail.com>
To: andrew@lunn.ch, f.fainelli@gmail.com, hkallweit1@gmail.com,
	linux@armlinux.org.uk, davem@davemloft.net, corbet@lwn.net,
	tglx@linutronix.de, gregkh@linuxfoundation.org,
	allison@lohutok.net, mchehab+samsung@kernel.org,
	netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Dejin Zheng <zhengdejin5@gmail.com>
Subject: [PATCH net-next v7 00/10] introduce read_poll_timeout
Date: Mon, 23 Mar 2020 23:05:50 +0800	[thread overview]
Message-ID: <20200323150600.21382-1-zhengdejin5@gmail.com> (raw)

This patch sets is introduce read_poll_timeout macro, it is an extension
of readx_poll_timeout macro. the accessor function op just supports only
one parameter in the readx_poll_timeout macro, but this macro can
supports multiple variable parameters for it. so functions like
phy_read(struct phy_device *phydev, u32 regnum) and
phy_read_mmd(struct phy_device *phydev, int devad, u32 regnum) can
use this poll timeout framework.

the first patch introduce read_poll_timeout macro, and the second patch
redefined readx_poll_timeout macro by read_poll_timeout(), and the other
patches are examples using read_poll_timeout macro.

v6 -> v7:
	- add a parameter to supports that it can sleep some time
	  before read operation in read_poll_timeout macro.
	- add prefix with double underscores for some variable to avoid
	  any variable re-declaration or shadowing in patch 3 and patch
	  7.
v5 -> v6:
	- add some check to keep the code more similar in patch 8
v4 -> v5:
	- add some msleep() before call phy_read_mmd_poll_timeout() to
	  keep the code more similar in patch 6 and patch 9.
	- add a patch of drop by v4, it can add msleep before call
	  phy_read_poll_timeout() to keep the code more similar.
v3 -> v4:
	- add 3 examples of using new functions.
	- deal with precedence issues for parameter cond.
	- drop a patch about phy_poll_reset() function.
v2 -> v3:
	- modify the parameter order of newly added functions.
	  phy_read_mmd_poll_timeout(val, cond, sleep_us, timeout_us, \
				     phydev, devaddr, regnum)
				||
				\/
	  phy_read_mmd_poll_timeout(phydev, devaddr regnum, val, cond, \
				    sleep_us, timeout_us)

	  phy_read_poll_timeout(val, cond, sleep_us, timeout_us, \
				phydev, regnum)
				||
				\/
	  phy_read_poll_timeout(phydev, regnum, val, cond, sleep_us, \
				timeout_us)
v1 -> v2:
	- passed a phydev, device address and a reg to replace args...
	  parameter in phy_read_mmd_poll_timeout() by Andrew Lunn 's
	  suggestion in patch 3. Andrew Lunn <andrew@lunn.ch>, Thanks
	  very much for your help!
	- also in patch 3, handle phy_read_mmd return an error(the return
	  value < 0) in phy_read_mmd_poll_timeout(). Thanks Andrew
	  again.
	- in patch 6, pass a phydev and a reg to replace args...
	  parameter in phy_read_poll_timeout(), and also handle the
	  phy_read() function's return error.

Dejin Zheng (10):
  iopoll: introduce read_poll_timeout macro
  iopoll: redefined readx_poll_timeout macro to simplify the code
  net: phy: introduce phy_read_mmd_poll_timeout macro
  net: phy: bcm84881: use phy_read_mmd_poll_timeout() to simplify the
    code
  net: phy: aquantia: use phy_read_mmd_poll_timeout() to simplify the
    code
  net: phy: marvell10g: use phy_read_mmd_poll_timeout() to simplify the
    code
  net: phy: introduce phy_read_poll_timeout macro
  net: phy: use phy_read_poll_timeout() to simplify the code
  net: phy: smsc: use phy_read_poll_timeout() to simplify the code
  net: phy: tja11xx: use phy_read_poll_timeout() to simplify the code

 drivers/net/phy/aquantia_main.c | 13 ++++-------
 drivers/net/phy/bcm84881.c      | 27 ++++------------------
 drivers/net/phy/marvell10g.c    | 15 +++++--------
 drivers/net/phy/nxp-tja11xx.c   | 16 +++----------
 drivers/net/phy/phy_device.c    | 16 +++++--------
 drivers/net/phy/smsc.c          | 16 +++++--------
 include/linux/iopoll.h          | 40 +++++++++++++++++++++++++++------
 include/linux/phy.h             | 27 ++++++++++++++++++++++
 8 files changed, 86 insertions(+), 84 deletions(-)

-- 
2.25.0


             reply	other threads:[~2020-03-23 15:06 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-23 15:05 Dejin Zheng [this message]
2020-03-23 15:05 ` [PATCH net-next v7 01/10] iopoll: introduce read_poll_timeout macro Dejin Zheng
2020-03-23 15:05 ` [PATCH net-next v7 02/10] iopoll: redefined readx_poll_timeout macro to simplify the code Dejin Zheng
2020-03-23 15:05 ` [PATCH net-next v7 03/10] net: phy: introduce phy_read_mmd_poll_timeout macro Dejin Zheng
2020-03-23 15:05 ` [PATCH net-next v7 04/10] net: phy: bcm84881: use phy_read_mmd_poll_timeout() to simplify the code Dejin Zheng
2020-03-23 15:05 ` [PATCH net-next v7 05/10] net: phy: aquantia: " Dejin Zheng
2020-03-23 15:05 ` [PATCH net-next v7 06/10] net: phy: marvell10g: " Dejin Zheng
2020-03-23 15:05 ` [PATCH net-next v7 07/10] net: phy: introduce phy_read_poll_timeout macro Dejin Zheng
2020-03-23 15:05 ` [PATCH net-next v7 08/10] net: phy: use phy_read_poll_timeout() to simplify the code Dejin Zheng
2020-03-23 15:05 ` [PATCH net-next v7 09/10] net: phy: smsc: " Dejin Zheng
2020-06-01 19:05   ` Kevin Groeneveld
     [not found]   ` <CABF+-6W-yo=CzaMaASdRGm5TS-JCnC5kGwPZHMce9OLPDCUw-g@mail.gmail.com>
2020-06-02 16:30     ` Dejin Zheng
2020-03-23 15:06 ` [PATCH net-next v7 10/10] net: phy: tja11xx: " Dejin Zheng
2020-03-24  5:00 ` [PATCH net-next v7 00/10] introduce read_poll_timeout David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200323150600.21382-1-zhengdejin5@gmail.com \
    --to=zhengdejin5@gmail.com \
    --cc=allison@lohutok.net \
    --cc=andrew@lunn.ch \
    --cc=corbet@lwn.net \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hkallweit1@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mchehab+samsung@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®