From: Philipp Zabel <pza@pengutronix.de>
To: Adrian Ratiu <adrian.ratiu@collabora.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
Ezequiel Garcia <ezequiel@collabora.com>,
kernel@collabora.com, kernel@pengutronix.de,
Tim Harvey <tharvey@gateworks.com>
Subject: Re: [PATCH 2/2] media: coda: be more flexible wrt jpeg dimensions
Date: Tue, 24 Mar 2020 10:21:31 +0100 [thread overview]
Message-ID: <20200324092131.GB12488@pengutronix.de> (raw)
In-Reply-To: <20200323130937.3666244-3-adrian.ratiu@collabora.com>
Hi Adrian,
On Mon, Mar 23, 2020 at 03:09:37PM +0200, Adrian Ratiu wrote:
> Don't require jpeg dimensions to exactly match format dimensions,
> so we are able to decode and display a wider range jpegs instead
> of outright rejecting the ones which don't match.
I don't think this is right. If userspace feeds us an incomatible
JPEG we should probably stop decoding and send a source change
event instead [1].
[1] https://linuxtv.org/downloads/v4l-dvb-apis-new/uapi/v4l/dev-decoder.html#dynamic-resolution-change
regards
Philipp
next prev parent reply other threads:[~2020-03-24 9:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-23 13:09 [PATCH 0/2] media: coda: Add ability to decode wider range of jpegs Adrian Ratiu
2020-03-23 13:09 ` [PATCH 1/2] media: coda: jpeg: support optimized huffman tables Adrian Ratiu
2020-03-24 9:11 ` Philipp Zabel
2020-03-23 13:09 ` [PATCH 2/2] media: coda: be more flexible wrt jpeg dimensions Adrian Ratiu
2020-03-23 14:27 ` Ezequiel Garcia
2020-03-24 9:21 ` Philipp Zabel [this message]
2020-03-24 11:14 ` Adrian Ratiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200324092131.GB12488@pengutronix.de \
--to=pza@pengutronix.de \
--cc=adrian.ratiu@collabora.com \
--cc=ezequiel@collabora.com \
--cc=kernel@collabora.com \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=tharvey@gateworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®