Re: [PATCH] tty: serial: make SERIAL_SPRD depends on ARM or ARM64

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Tue, Mar 24, 2020 at 02:49:49PM +0800, Chunyan Zhang wrote:
> From: Chunyan Zhang <chunyan.zhang@unisoc.com>
> 
> kbuild-test reported an error:
> 
>   config: mips-randconfig-a001-20200321 ...
>   >> drivers/tty/serial/sprd_serial.c:1175: undefined reference
>   to `clk_set_parent'
> 
> Because some mips Kconfig-s select CONFIG_HAVE_CLK but not CONFIG_COMMON_CLK,
> so it's probably that clk_set_parent is missed for those configs.
> 
> To fix this error, this patch adds dependence on ARM || ARM64
> for SERIAL_SPRD.
> 
> Fixes: 7ba87cfec71a ("tty: serial: make SERIAL_SPRD not depend on ARCH_SPRD")
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Chunyan Zhang <chunyan.zhang@unisoc.com>
> ---
>  drivers/tty/serial/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
> index b43dce785a58..417f7e45a3f8 100644
> --- a/drivers/tty/serial/Kconfig
> +++ b/drivers/tty/serial/Kconfig
> @@ -1444,6 +1444,7 @@ config SERIAL_MEN_Z135
>  config SERIAL_SPRD
>  	tristate "Support for Spreadtrum serial"
>  	select SERIAL_CORE
> +	depends on ARM || ARM64 || COMPILE_TEST

Why not just depend on the proper CLK config option instead?

thanks,

greg k-h