From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82C10C10DCE for ; Tue, 24 Mar 2020 22:05:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5E96C2076F for ; Tue, 24 Mar 2020 22:05:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728294AbgCXWFi (ORCPT ); Tue, 24 Mar 2020 18:05:38 -0400 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:42583 "EHLO relay7-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727753AbgCXWFi (ORCPT ); Tue, 24 Mar 2020 18:05:38 -0400 X-Originating-IP: 91.224.148.103 Received: from localhost.localdomain (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id C461E20004; Tue, 24 Mar 2020 22:05:34 +0000 (UTC) From: Miquel Raynal To: Xiaoming Ni , miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com Cc: linux-mtd@lists.infradead.org, zhangweimin12@huawei.com, wangle6@huawei.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mtd:Fix issue where write_cached_data() fails but write() still returns success Date: Tue, 24 Mar 2020 23:05:33 +0100 Message-Id: <20200324220533.15273-1-miquel.raynal@bootlin.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <1584674111-101462-1-git-send-email-nixiaoming@huawei.com> References: MIME-Version: 1.0 X-linux-mtd-patch-notification: thanks X-linux-mtd-patch-commit: 4e4a9a828af29785fad12ecc11583769e1282024 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2020-03-20 at 03:15:11 UTC, Xiaoming Ni wrote: > mtdblock_flush() > -->write_cached_data() > --->erase_write() > mtdblock: erase of region [0x40000, 0x20000] on "xxx" failed > > Because mtdblock_flush() always returns 0, > even if write_cached_data() fails and data is not written to the device, > syscall_write() still returns success > > Signed-off-by: Xiaoming Ni Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks. Miquel