From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E9BDC1975A for ; Wed, 25 Mar 2020 13:36:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0BD9E2076A for ; Wed, 25 Mar 2020 13:36:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728091AbgCYNgv (ORCPT ); Wed, 25 Mar 2020 09:36:51 -0400 Received: from esa3.mentor.iphmx.com ([68.232.137.180]:53281 "EHLO esa3.mentor.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727656AbgCYNgt (ORCPT ); Wed, 25 Mar 2020 09:36:49 -0400 IronPort-SDR: BBLp2cZZVJA3Tprc9xsnZHKF40uzrZ5qKXYNOYmlU/rJqJmPvAACKUzzgCl8lHqVZXVLrkkMxQ SkOnky6dLxKEj9Dg7J/8v6cGu41vQzB9bfeV6iaTFuwkYyYqysO6zLq1InYnomRX9r6qnjRM7y d09sUd6oOkpJdn3xpTnBZMgHCa7Ve9uCJx1+GHotG9swvuEXgFWVNFVPqJ/uPDnBnYH4kYzFLl GYF3Rwo9q+WkpRTikJCAnHEJomX1Ijf4uONo3bKirbdp9pWoF4jPsqE4AxTWtpsh9s06az0qsA NLk= X-IronPort-AV: E=Sophos;i="5.72,304,1580803200"; d="scan'208";a="47099827" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa3.mentor.iphmx.com with ESMTP; 25 Mar 2020 05:36:48 -0800 IronPort-SDR: OG6R1QgU6QCRNZYh6/i9lD0NZki/HC/AUdRIqzmnDjXG3G3h6sDjxQ8Y2kfNj47S9vyhm0cOdR 9Wpf3Uv8gVTjWaaKMbdRLsHsr/fpA71eREV0T6XgsxYrPqkekbm7WwDcLwfmFokRONO3xOfdFe qrifl1QI6TCwZgsP0c1UcRp4V9WxTa3kM4H5gPIn5ejyhKj1JoydcQqzsaaTvuyFXlaZIBo28K j94JUSJOeIK9rVluQMrKXIxxgYHAuB+K6b9hdOF1XByVxjhlO2iz4MOcyI/helCRMu5U1HF2yV lyI= From: Jiada Wang To: , , , , , CC: , , , , Subject: [PATCH v9 47/55] Input: Atmel: improve error handling in mxt_update_cfg() Date: Wed, 25 Mar 2020 06:33:26 -0700 Message-ID: <20200325133334.19346-48-jiada_wang@mentor.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200325133334.19346-1-jiada_wang@mentor.com> References: <20200325133334.19346-1-jiada_wang@mentor.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Deepak Das mxt_update_cfg() failed to propagate the error code from mxt_init_t7_power_cfg() so return the error code. Signed-off-by: Deepak Das Signed-off-by: George G. Davis Signed-off-by: Jiada Wang --- drivers/input/touchscreen/atmel_mxt_ts.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers/input/touchscreen/atmel_mxt_ts.c index 258dcd8a68e5..069a532bd0b2 100644 --- a/drivers/input/touchscreen/atmel_mxt_ts.c +++ b/drivers/input/touchscreen/atmel_mxt_ts.c @@ -2185,7 +2185,9 @@ static int mxt_update_cfg(struct mxt_data *data, const struct firmware *fw) dev_info(dev, "Config successfully updated\n"); /* T7 config may have changed */ - mxt_init_t7_power_cfg(data); + ret = mxt_init_t7_power_cfg(data); + if (ret) + dev_warn(dev, "Power Config failed to update\n"); release_mem: kfree(cfg.mem); -- 2.17.1