From: Maxime Ripard <maxime@cerno.tech>
To: Stephen Boyd <sboyd@kernel.org>
Cc: Michael Turquette <mturquette@baylibre.com>,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH] clk: Pass correct arguments to __clk_hw_register_gate()
Date: Wed, 25 Mar 2020 16:32:00 +0100 [thread overview]
Message-ID: <20200325153200.6vdgglrirhpl4yh6@gilmour.lan> (raw)
In-Reply-To: <158510329289.125146.2737057581185153152@swboyd.mtv.corp.google.com>
[-- Attachment #1: Type: text/plain, Size: 1206 bytes --]
On Tue, Mar 24, 2020 at 07:28:12PM -0700, Stephen Boyd wrote:
> Quoting Stephen Boyd (2020-03-24 19:22:57)
> > diff --git a/include/linux/clk-provider.h b/include/linux/clk-provider.h
> > index 952ac035bab9..95cc8a4f6e39 100644
> > --- a/include/linux/clk-provider.h
> > +++ b/include/linux/clk-provider.h
> > @@ -539,10 +539,10 @@ struct clk *clk_register_gate(struct device *dev, const char *name,
> > * @clk_gate_flags: gate-specific flags for this clock
> > * @lock: shared register lock for this clock
> > */
> > -#define clk_hw_register_gate_parent_data(dev, name, parent_name, flags, reg, \
> > +#define clk_hw_register_gate_parent_data(dev, name, parent_data, flags, reg, \
> > bit_idx, clk_gate_flags, lock) \
> > - __clk_hw_register_gate((dev), NULL, (name), (parent_name), NULL, \
> > - NULL, (flags), (reg), (bit_idx), \
> > + __clk_hw_register_gate((dev), NULL, (name), NULL, NULL, (parent_data) \
>
> And this needs a comma after it.
>
> I'll apply this to clk-fixes and send to Linus in the next few days.
With that fix,
Tested-by: Maxime Ripard <mripard@kernel.org>
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2020-03-25 15:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-25 2:22 Stephen Boyd
2020-03-25 2:28 ` Stephen Boyd
2020-03-25 15:32 ` Maxime Ripard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200325153200.6vdgglrirhpl4yh6@gilmour.lan \
--to=maxime@cerno.tech \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®