From: Greg KH <gregkh@linuxfoundation.org>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: linux-kernel@vger.kernel.org, nicholas.johnson-opensource@outlook.com.au
Subject: Re: [PATCH v4 0/2] nvmem: use is_bin_visible callback
Date: Wed, 25 Mar 2020 19:24:59 +0100 [thread overview]
Message-ID: <20200325182459.GA3801107@kroah.com> (raw)
In-Reply-To: <20200325131951.31887-1-srinivas.kandagatla@linaro.org>
On Wed, Mar 25, 2020 at 01:19:49PM +0000, Srinivas Kandagatla wrote:
> As suggested I managed to use is_bin_visible for the existing code
> and also added few more checks for callbacks before setting
> permissions on the file. Which also means that Thunderbolt case
> for write-only should be fixed automatically with this patch.
>
> As part of this cleanup it does not make any sense to keep
> nvmem-sysfs.c and nvmem.h anymore, so move all the relevant
> code to core.c
>
> Changes since v3:
> - Split patch2 in to two patches for better review.
> - drop first patch to add root_only as its queued
Much nicer, and easier to follow, thanks for doing that.
All now queued up, if I've missed anything, please let me know.
greg k-h
prev parent reply other threads:[~2020-03-25 18:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-25 13:19 Srinivas Kandagatla
2020-03-25 13:19 ` [PATCH v4 1/2] nvmem: core: use is_bin_visible for permissions Srinivas Kandagatla
2020-03-25 13:19 ` [PATCH v4 2/2] nvmem: core: remove nvmem_sysfs_get_groups() Srinivas Kandagatla
2020-03-25 18:24 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200325182459.GA3801107@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicholas.johnson-opensource@outlook.com.au \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®