From: Joel Fernandes <joel@joelfernandes.org>
To: Tejun Heo <tj@kernel.org>
Cc: Sonny Rao <sonnyrao@google.com>, Waiman Long <longman@redhat.com>,
linux-kernel@vger.kernel.org,
Dmitry Shmidt <dimitrysh@google.com>,
Amit Pundir <amit.pundir@linaro.org>,
kernel-team@android.com, Jesse Barnes <jsbarnes@google.com>,
vpillai@digitalocean.com, Peter Zijlstra <peterz@infradead.org>,
Guenter Roeck <groeck@chromium.org>,
Greg Kerr <kerrnel@google.com>,
cgroups@vger.kernel.org, Johannes Weiner <hannes@cmpxchg.org>,
Li Zefan <lizefan@huawei.com>
Subject: Re: [PATCH RFC] cpuset: Make cpusets get restored on hotplug
Date: Thu, 26 Mar 2020 16:23:40 -0400 [thread overview]
Message-ID: <20200326202340.GA146657@google.com> (raw)
In-Reply-To: <20200326201649.GQ162390@mtj.duckdns.org>
On Thu, Mar 26, 2020 at 04:18:59PM -0400, Tejun Heo wrote:
> On Thu, Mar 26, 2020 at 01:05:04PM -0700, Sonny Rao wrote:
> > I am surprised if anyone actually wants this behavior, we (Chrome OS)
>
> The behavior is silly but consistent in that it doesn't allow empty active
> cpusets and it has been like that for many many years now.
>
> > found out about it accidentally, and then found that Android had been
> > carrying a patch to fix it. And if it were a desirable behavior then
> > why isn't it an option in v2?
>
> Nobody is saying it's a good behavior (hence the change in cgroup2) and there
> are situations where changing things like this is justifiable, but, here:
>
> * The proposed change makes the interface inconsistent and does so
> unconditionally on what is now a mostly legacy interface.
>
> * There already is a newer version of the interface which includes the
> desired behavior.
>
> * I forgot but as Waiman pointed out, you can even opt-in to the new
> behavior, which is more comprehensive without the inconsitencies,
> while staying on cgroup1.
Thank you Tejun, Waiman and Sonny. I confirmed the cgroup_v2_mode option
fixes cgroup v1's broken behavior.
We will use this mount option on our systems to fix it.
thanks,
- Joel
next prev parent reply other threads:[~2020-03-26 20:23 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-26 19:16 Joel Fernandes (Google)
2020-03-26 19:20 ` Tejun Heo
2020-03-26 19:44 ` Joel Fernandes
2020-03-26 19:48 ` Tejun Heo
2020-03-26 19:57 ` Waiman Long
2020-03-26 20:05 ` Sonny Rao
2020-03-26 20:18 ` Tejun Heo
2020-03-26 20:23 ` Joel Fernandes [this message]
2020-03-27 1:26 ` Waiman Long
2020-03-27 3:32 ` Joel Fernandes
2020-03-26 21:47 ` Waiman Long
2020-03-26 22:03 ` Sonny Rao
2021-10-26 23:58 ` Barry Song
2021-10-27 1:06 ` Waiman Long
2021-10-27 2:21 ` Barry Song
2021-10-27 2:35 ` Waiman Long
2021-10-27 2:42 ` Barry Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200326202340.GA146657@google.com \
--to=joel@joelfernandes.org \
--cc=amit.pundir@linaro.org \
--cc=cgroups@vger.kernel.org \
--cc=dimitrysh@google.com \
--cc=groeck@chromium.org \
--cc=hannes@cmpxchg.org \
--cc=jsbarnes@google.com \
--cc=kernel-team@android.com \
--cc=kerrnel@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=longman@redhat.com \
--cc=peterz@infradead.org \
--cc=sonnyrao@google.com \
--cc=tj@kernel.org \
--cc=vpillai@digitalocean.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome