From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E476CC43331 for ; Fri, 27 Mar 2020 02:46:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B66812074D for ; Fri, 27 Mar 2020 02:46:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727755AbgC0CqW (ORCPT ); Thu, 26 Mar 2020 22:46:22 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:34355 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726363AbgC0CqW (ORCPT ); Thu, 26 Mar 2020 22:46:22 -0400 Received: from 61-220-137-37.hinet-ip.hinet.net ([61.220.137.37] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1jHf0Z-0002zW-PR; Fri, 27 Mar 2020 02:46:08 +0000 From: Kai-Heng Feng To: davem@davemloft.net, kuba@kernel.org Cc: alexander.duyck@gmail.com, Kai-Heng Feng , Jeff Kirsher , Aaron Brown , Michal Kubecek , Florian Fainelli , Andrew Lunn , Maxime Chevallier , netdev@vger.kernel.org (open list:NETWORKING [GENERAL]), linux-kernel@vger.kernel.org (open list) Subject: [PATCH] ethtool: Report speed and duplex as unknown when device is runtime suspended Date: Fri, 27 Mar 2020 10:45:51 +0800 Message-Id: <20200327024552.22170-1-kai.heng.feng@canonical.com> X-Mailer: git-send-email 2.17.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Device like igb gets runtime suspended when there's no link partner. We can't get correct speed under that state: $ cat /sys/class/net/enp3s0/speed 1000 In addition to that, an error can also be spotted in dmesg: [ 385.991957] igb 0000:03:00.0 enp3s0: PCIe link lost Since device can only be runtime suspended when there's no link partner, we can directly report the speed and duplex as unknown. Cc: Jeff Kirsher Cc: Aaron Brown Suggested-by: Alexander Duyck Signed-off-by: Kai-Heng Feng --- net/ethtool/ioctl.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/net/ethtool/ioctl.c b/net/ethtool/ioctl.c index 10d929abdf6a..2ba04aa9d775 100644 --- a/net/ethtool/ioctl.c +++ b/net/ethtool/ioctl.c @@ -28,6 +28,7 @@ #include #include #include +#include #include "common.h" @@ -429,6 +430,13 @@ int __ethtool_get_link_ksettings(struct net_device *dev, return -EOPNOTSUPP; memset(link_ksettings, 0, sizeof(*link_ksettings)); + + if (pm_runtime_suspended(dev->dev.parent)) { + link_ksettings->base.duplex = DUPLEX_UNKNOWN; + link_ksettings->base.speed = SPEED_UNKNOWN; + return 0; + } + return dev->ethtool_ops->get_link_ksettings(dev, link_ksettings); } EXPORT_SYMBOL(__ethtool_get_link_ksettings); -- 2.17.1