mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: David Ahern <dsahern@kernel.org>
Cc: linux-kernel@vger.kernel.org, Yafang Shao <laoar.shao@gmail.com>,
	Johannes Berg <johannes@sipsolutions.net>,
	Shailabh Nagar <nagar@watson.ibm.com>
Subject: Re: [PATCH] getdelays: Fix netlink attribute length
Date: Sat, 28 Mar 2020 13:03:41 -0700	[thread overview]
Message-ID: <20200328130341.a23be12b3a0f4cf0288a0d84@linux-foundation.org> (raw)
In-Reply-To: <20200327173111.63922-1-dsahern@kernel.org>

On Fri, 27 Mar 2020 11:31:11 -0600 David Ahern <dsahern@kernel.org> wrote:

> A recent change to the netlink code:
>   6e237d099fac ("netlink: Relax attr validation for fixed length types")
> logs a warning when programs send messages with invalid attributes
> (e.g., wrong length for a u32). Yafang reported this error message
> for tools/accounting/getdelays.c.
> 
> send_cmd() is wrongly adding 1 to the attribute length. As noted in
> include/uapi/linux/netlink.h nla_len should be NLA_HDRLEN + payload
> length, so drop the +1.

Thanks.

> Fixes: 9e06d3f9f6b1 ("per task delay accounting taskstats interface: documentation fix")
> Signed-off-by: David Ahern <dsahern@kernel.org>
> Tested-by: Yafang Shao <laoar.shao@gmail.com>

I'll add Reported-by: as well.

> Cc: Johannes Berg <johannes@sipsolutions.net>
> Cc: Shailabh Nagar <nagar@watson.ibm.com>

Is this worth a cc:stable?



  reply	other threads:[~2020-03-28 20:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-27 17:31 David Ahern
2020-03-28 20:03 ` Andrew Morton [this message]
2020-03-29 15:44   ` David Ahern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200328130341.a23be12b3a0f4cf0288a0d84@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=dsahern@kernel.org \
    --cc=johannes@sipsolutions.net \
    --cc=laoar.shao@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nagar@watson.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome