mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@kernel.org>
To: "Joel Fernandes (Google)" <joel@joelfernandes.org>
Cc: linux-kernel@vger.kernel.org, Andy Lutomirski <luto@kernel.org>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	frextrite@gmail.com, Ingo Molnar <mingo@redhat.com>,
	Josh Triplett <josh@joshtriplett.org>,
	kernel-team@android.com, Lai Jiangshan <jiangshanlai@gmail.com>,
	madhuparnabhowmik04@gmail.com,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	peterz@infradead.org, Petr Mladek <pmladek@suse.com>,
	rcu@vger.kernel.org, rostedt@goodmis.org, tglx@linutronix.de,
	vpillai@digitalocean.com
Subject: Re: [PATCH v2 0/4] RCU dyntick nesting counter cleanups
Date: Sat, 28 Mar 2020 16:43:06 -0700	[thread overview]
Message-ID: <20200328234306.GC19865@paulmck-ThinkPad-P72> (raw)
In-Reply-To: <20200328221703.48171-1-joel@joelfernandes.org>

On Sat, Mar 28, 2020 at 06:16:59PM -0400, Joel Fernandes (Google) wrote:
> These patches clean up the usage of dynticks nesting counters simplifying the
> code, while preserving the usecases.
> 
> It is a much needed simplification, makes the code less confusing, and prevents
> future bugs such as those that arise from forgetting that the
> dynticks_nmi_nesting counter is not a simple counter and can be "crowbarred" in
> common situations.
> 
> rcutorture testing with all TREE RCU configurations succeed with
> CONFIG_RCU_EQS_DEBUG=y and CONFIG_PROVE_LOCKING=y.

Heh!  We now have a three-way collision between Thomas's and Peter's
series, the RCU Tasks Trace series, and this series.  ;-)

Remind me once v5.7-rc1 comes out and let's see what fits where.

							Thanx, Paul

> v1->v2:
> - Rebase on v5.6-rc6
> 
> Joel Fernandes (Google) (4):
> Revert b8c17e6664c4 ("rcu: Maintain special bits at bottom of
> ->dynticks counter")
> rcu/tree: Add better tracing for dyntick-idle
> rcu/tree: Clean up dynticks counter usage
> rcu/tree: Remove dynticks_nmi_nesting counter
> 
> .../Data-Structures/Data-Structures.rst       |  31 +--
> Documentation/RCU/stallwarn.txt               |   6 +-
> include/linux/rcutiny.h                       |   3 -
> include/trace/events/rcu.h                    |  29 +--
> kernel/rcu/rcu.h                              |   4 -
> kernel/rcu/tree.c                             | 188 +++++++-----------
> kernel/rcu/tree.h                             |   4 +-
> kernel/rcu/tree_stall.h                       |   4 +-
> 8 files changed, 105 insertions(+), 164 deletions(-)
> 
> --
> 2.26.0.rc2.310.g2932bb562d-goog
> 

  parent reply	other threads:[~2020-03-28 23:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-28 22:16 Joel Fernandes (Google)
2020-03-28 22:17 ` [PATCH v2 1/4] Revert b8c17e6664c4 ("rcu: Maintain special bits at bottom of ->dynticks counter") Joel Fernandes (Google)
2020-03-28 22:17 ` [PATCH v2 2/4] rcu/tree: Add better tracing for dyntick-idle Joel Fernandes (Google)
2020-03-28 22:17 ` [PATCH v2 3/4] rcu/tree: Clean up dynticks counter usage Joel Fernandes (Google)
2020-03-28 22:17 ` [PATCH v2 4/4] rcu/tree: Remove dynticks_nmi_nesting counter Joel Fernandes (Google)
2020-03-28 23:43 ` Paul E. McKenney [this message]
2020-03-28 23:56   ` [PATCH v2 0/4] RCU dyntick nesting counter cleanups Joel Fernandes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200328234306.GC19865@paulmck-ThinkPad-P72 \
    --to=paulmck@kernel.org \
    --cc=frextrite@gmail.com \
    --cc=fweisbec@gmail.com \
    --cc=jiangshanlai@gmail.com \
    --cc=joel@joelfernandes.org \
    --cc=josh@joshtriplett.org \
    --cc=kernel-team@android.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=madhuparnabhowmik04@gmail.com \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=pmladek@suse.com \
    --cc=rcu@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    --cc=vpillai@digitalocean.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome