From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 248B4C2D0EE for ; Mon, 30 Mar 2020 01:25:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EA162206F6 for ; Mon, 30 Mar 2020 01:25:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sgKwu5+n" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728358AbgC3BZJ (ORCPT ); Sun, 29 Mar 2020 21:25:09 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:40317 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728114AbgC3BZI (ORCPT ); Sun, 29 Mar 2020 21:25:08 -0400 Received: by mail-wr1-f65.google.com with SMTP id u10so19407250wro.7; Sun, 29 Mar 2020 18:25:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Q+wn7qClZIa1xvjg8Kd2b3s4VLOFfaASUxeqUySTijI=; b=sgKwu5+n0Uia+KnlO6EcWuTWx2zJhARlhaC8BOxOqymlDv3KuvEI3GAqdKg1NfdIgp wxvHQU/506JbLYgU3N2WMFFRr1qAr5pqG3xky5hX+1W1jGhGiSSw83t1WEeWTq32LNAE zEXII4fxL31YhcHVSiAM9gZN5An/uIbWoDDjkn0exd8aNgGpt7tN+2JMGdDfPrSayC1E +yC/WGNhxquiyTAFUECW+mysVcQqmBui3f0aYe4DtbcchOSow4iSiH7p4eN5yCe+sGzJ q4Vq4ifoWADg32vf5AcXTzGjVDDUast+dxIpA1yTnAfhOIKhk2eK6PhoZ3zabZNP9oTh VWWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Q+wn7qClZIa1xvjg8Kd2b3s4VLOFfaASUxeqUySTijI=; b=MwHuQQr6o14FpL9YzoHeLShpYQGNVWLzDHIf3cCrbdBRyetvG0kFD9em0HO0rsMtfJ pH39izUMtrQTDLdwAXrn12vT7oydiYYED8sBmEfQcItUUtWDPzca2oft/ZJT6L1JxRYR gReLaVUB5BMnnbnEKxxFwkVM5ii8N1qjcrrIj6yA7ANkQtaFyqCgn6NUu2K16js3wYZf ueNNhAGTqVYF3UXueKms5XoowzjElYRzjtUx9HJ02nvb8PcMa5xpyUt+rM4b55PDh+B+ J7fdOp0C5Hw9BrhYSiFNhq4+Kr9yYznAAIVQqjnuKkOHIUe1u5mzrWRjuyg2i/m7k6Wn pBQA== X-Gm-Message-State: ANhLgQ1BKT8kaUHOD1au5MjBmv4yTmW+IJPtSL9cO5N6K3kkCDijXzIV lJT74AmM38IsE4G9Kw73pcUb2VjPZoVy X-Google-Smtp-Source: ADFU+vt/BinZeFR3M5L3M0ZA506SMS9BDChv5VylzMerY3FGrvGMI7yNrAru49PShwTyG8C6eogAgQ== X-Received: by 2002:adf:fc51:: with SMTP id e17mr5565280wrs.2.1585531506703; Sun, 29 Mar 2020 18:25:06 -0700 (PDT) Received: from earth.lan (host-92-23-85-227.as13285.net. [92.23.85.227]) by smtp.gmail.com with ESMTPSA id f12sm18679545wmh.4.2020.03.29.18.25.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 29 Mar 2020 18:25:06 -0700 (PDT) From: Jules Irenge To: linux-kernel@vger.kernel.org Cc: julia.lawall@lip6.fr, boqun.feng@gmail.com, "Paul E. McKenney" , Josh Triplett , Steven Rostedt , Mathieu Desnoyers , Lai Jiangshan , Joel Fernandes , rcu@vger.kernel.org (open list:READ-COPY UPDATE (RCU)) Subject: [PATCH v2 2/4] rcu: Replace 1 by true Date: Mon, 30 Mar 2020 02:24:48 +0100 Message-Id: <20200330012450.312155-3-jbi.octave@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200330012450.312155-1-jbi.octave@gmail.com> References: <0/4> <20200330012450.312155-1-jbi.octave@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Coccinelle reports a warning at use_softirq declaration WARNING: Assignment of 0/1 to bool variable The root cause is use_softirq a variable of bool type is initialised with the integer 1 Replacing 1 with value true solve the issue. Signed-off-by: Jules Irenge --- kernel/rcu/tree.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c index d91c9156fab2..c2ffea31eae8 100644 --- a/kernel/rcu/tree.c +++ b/kernel/rcu/tree.c @@ -100,7 +100,7 @@ static struct rcu_state rcu_state = { static bool dump_tree; module_param(dump_tree, bool, 0444); /* By default, use RCU_SOFTIRQ instead of rcuc kthreads. */ -static bool use_softirq = 1; +static bool use_softirq = true; module_param(use_softirq, bool, 0444); /* Control rcu_node-tree auto-balancing at boot time. */ static bool rcu_fanout_exact; -- 2.25.1