From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22814C43331 for ; Mon, 30 Mar 2020 14:17:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E33402073B for ; Mon, 30 Mar 2020 14:17:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hEQTy+L5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728902AbgC3ORR (ORCPT ); Mon, 30 Mar 2020 10:17:17 -0400 Received: from mail-pf1-f193.google.com ([209.85.210.193]:40841 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728009AbgC3ORQ (ORCPT ); Mon, 30 Mar 2020 10:17:16 -0400 Received: by mail-pf1-f193.google.com with SMTP id c20so6094883pfi.7 for ; Mon, 30 Mar 2020 07:17:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=1BA/+EzZUprzyKG2z2k8xv+DKN8kyB5d20DyklGct+U=; b=hEQTy+L5QUjHFFy9HvIuA862khwr+dcNTcnqGoX9MYD23rZtSH2WE1dFMUAJomBuEX 9NoRKlLDQ9qBTZy43S4zEJGy7oCyQDNYVe5HHTcqjLPZv8+qPog5vCpY59V69NxT/pa0 QdssDNJ3PiOKf0ydCgslpMlDgxDa3mBAYqpKfMsR/Bpc94HdF21MVPoS4L+xd8vLmcHq lVpbwqorBl6WMuPsyIe9kA2Fq/4rgy8JSYVtTGE9x4HvkSwempVi06XtJK9M1KxJM1P6 f22VN0PFOjlhaU5GVr4PIdbinuHfmXmQGAQuOUfbkYpuwv1TKvSXABFZKSVoUN2scUJB +ywQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=1BA/+EzZUprzyKG2z2k8xv+DKN8kyB5d20DyklGct+U=; b=CGY6mdERLDgzHCyD5PRWDkD8UReNf0uv2penvY9illJ4KGIm/A2XiCVtPHXY9PdOOM vPspMKU82AR3AwWLC3eUBdMErxcQwyX8BN6uTCrKi0l6TaIzJR6dx0TAL+XIWjFd+0mC Z7xTU5zd1roj/l0RxvuMELSZVWP7aXwB88Bfepf3q+HCgkb8rXI/1z4j0bxgaPpNSdpA ic4vue0H2I9khGA47u3hAyiXIIxZxD0UD6XEb/X5TcvlhluclEIFeijquARHgmZ4QXNC rxNfYFcpx0fDb4N4aaKFahT/HFlk3xr/wZwRR1cmUBM+/5Nd1jnW7/onerfClCffks2G qFJw== X-Gm-Message-State: ANhLgQ2JaFbw1Op5CAeWVC8QjtlHvD9sWzvXuP5HGA6Z4CBqpTKK7eZo YUcF6Jn4l9icW5NoEV8ScFY= X-Google-Smtp-Source: ADFU+vtCjTYKqekOM0YDuD1qdXteoTtLiDzhYoTFy6qUg9m6sh/BwIAh7OT6nOcgScsMrNlivQrPSQ== X-Received: by 2002:a63:790e:: with SMTP id u14mr12317600pgc.361.1585577835411; Mon, 30 Mar 2020 07:17:15 -0700 (PDT) Received: from localhost.net ([131.107.159.147]) by smtp.googlemail.com with ESMTPSA id o3sm848855pgk.21.2020.03.30.07.17.14 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 30 Mar 2020 07:17:14 -0700 (PDT) From: ltykernel@gmail.com X-Google-Original-From: Tianyu.Lan@microsoft.com To: kys@microsoft.com, haiyangz@microsoft.com, sthemmin@microsoft.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, x86@kernel.org, michael.h.kelley@microsoft.com, wei.liu@kernel.org Cc: Tianyu Lan , devel@linuxdriverproject.org, linux-kernel@vger.kernel.org, vkuznets@redhat.com Subject: [Update PATCH] x86/Hyper-V: Initialize Syn timer clock when it's Date: Mon, 30 Mar 2020 07:17:08 -0700 Message-Id: <20200330141708.12822-1-Tianyu.Lan@microsoft.com> X-Mailer: git-send-email 2.14.5 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tianyu Lan Current code initializes clock event data structure for syn timer even when it's not available. Fix it. Signed-off-by: Tianyu Lan --- - Fix the wrong title. drivers/hv/hv.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/hv/hv.c b/drivers/hv/hv.c index 632d25674e7f..2e893768fc76 100644 --- a/drivers/hv/hv.c +++ b/drivers/hv/hv.c @@ -212,13 +212,16 @@ int hv_synic_alloc(void) tasklet_init(&hv_cpu->msg_dpc, vmbus_on_msg_dpc, (unsigned long) hv_cpu); - hv_cpu->clk_evt = kzalloc(sizeof(struct clock_event_device), - GFP_KERNEL); - if (hv_cpu->clk_evt == NULL) { - pr_err("Unable to allocate clock event device\n"); - goto err; + if (ms_hyperv.features & HV_MSR_SYNTIMER_AVAILABLE) { + hv_cpu->clk_evt = + kzalloc(sizeof(struct clock_event_device), + GFP_KERNEL); + if (hv_cpu->clk_evt == NULL) { + pr_err("Unable to allocate clock event device\n"); + goto err; + } + hv_init_clockevent_device(hv_cpu->clk_evt, cpu); } - hv_init_clockevent_device(hv_cpu->clk_evt, cpu); hv_cpu->synic_message_page = (void *)get_zeroed_page(GFP_ATOMIC); -- 2.14.5