From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2104EC2D0EF for ; Tue, 31 Mar 2020 07:47:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EA8D120780 for ; Tue, 31 Mar 2020 07:47:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="Gr0LvrHj" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730040AbgCaHrZ (ORCPT ); Tue, 31 Mar 2020 03:47:25 -0400 Received: from mail-wm1-f65.google.com ([209.85.128.65]:53961 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726299AbgCaHrZ (ORCPT ); Tue, 31 Mar 2020 03:47:25 -0400 Received: by mail-wm1-f65.google.com with SMTP id b12so1356095wmj.3 for ; Tue, 31 Mar 2020 00:47:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=9TfK1u1VpPaq5iA6J1WQwLfjQ6lOwx15msGpVq0i+7c=; b=Gr0LvrHjjJ5qr8lqINKW/3hKNpu+pFwzsUq58/tgAuectYIefxdFpYIe+jeXnMPUjx IGmkhlcbkNL3xDq8h6ZFf0EodqpQVZ/RFZnQCKmXl8eJtE5KyCfZI3TTJfvGIjBuYZdw 8JKTetKFESliIYV8V4jLl7aJjPMuplmWL/SzA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=9TfK1u1VpPaq5iA6J1WQwLfjQ6lOwx15msGpVq0i+7c=; b=cF5dOj9wPRTFTbwDcjIuYuhmWk+s903lEk/AdouX6LxAI/ibWz9SH11UyJGIgagqfg C27FQFOhwJxESLa7oP1MnHslvi2Bd3xrEnhaxL+DrFHp/ZwJo+liQ9AIj+uXqtZfsvep I6WsmBHocDIWWO6gDDlhEdpHDxKUxMwzFe0sIzXEdAXbspmzdYe5r8Hyo77KnMHz4Jiv XLwa77+18o6HnNhLbKhvYQwbHHiCXNJxJ7ByPpqdQQy0HDEXAeLJr0UeBZDqwciXRod0 DKDwPhTGgz0DzYlhsIISXaIz0R4Cbxk2CM3iXmUad2uJ+rJjJD90KHdhXU0MNND5pEqU aRLg== X-Gm-Message-State: ANhLgQ1c/4ANYXjq4WV+KfnoLN5OAx2sqHVLdoY/yVdnxAW0RpgDtGvs CpRY0LzPJUMC6ZdZsQmHXty49g== X-Google-Smtp-Source: ADFU+vtayUlqbWaVjEdDpSf+eVK+fU90P3qYqeML/NIzR7pnIBLOepUFWDkVMvgCmV92cYRgJios+A== X-Received: by 2002:a7b:cd02:: with SMTP id f2mr1981956wmj.97.1585640843372; Tue, 31 Mar 2020 00:47:23 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id t21sm2795111wmt.43.2020.03.31.00.47.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2020 00:47:22 -0700 (PDT) Date: Tue, 31 Mar 2020 09:47:20 +0200 From: Daniel Vetter To: Julia Lawall Cc: Daniel Vetter , kbuild-all@lists.01.org, Sam Ravnborg , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm: fix ifnullfree.cocci warnings Message-ID: <20200331074720.GD2363188@phenom.ffwll.local> Mail-Followup-To: Julia Lawall , kbuild-all@lists.01.org, Sam Ravnborg , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Operating-System: Linux phenom 5.3.0-3-amd64 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 27, 2020 at 09:11:44AM +0100, Julia Lawall wrote: > NULL check before kfree is not needed. > > Generated by: scripts/coccinelle/free/ifnullfree.cocci > > Fixes: c6603c740e0e ("drm: add managed resources tied to drm_device") > Signed-off-by: kbuild test robot > Signed-off-by: Julia Lawall > --- > > tree: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next Hm this doesn't apply anymore, the patch is for an interim state (because bisectability). Care to regen (the pattern still exists), I'm happy to apply. -Daniel > head: 9e1ed9fb1eb0a4bc43a26365c592d3095286038b > commit: c6603c740e0e3492c9c95fdab833375bf7117b6b [1587/1636] drm: add managed resources tied to drm_device > :::::: branch date: 8 hours ago > :::::: commit date: 9 hours ago > > Up to you, if you tihnk it is useful... > > drm_drv.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > --- a/drivers/gpu/drm/drm_drv.c > +++ b/drivers/gpu/drm/drm_drv.c > @@ -837,8 +837,9 @@ static void drm_dev_release(struct kref > if (!dev->driver->release && !dev->managed.final_kfree) { > WARN_ON(!list_empty(&dev->managed.resources)); > kfree(dev); > - } else if (dev->managed.final_kfree) > + } else { > kfree(dev->managed.final_kfree); > + } > } > > /** -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch