From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8782C2D0EE for ; Tue, 31 Mar 2020 12:26:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 735B1208E4 for ; Tue, 31 Mar 2020 12:26:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585657590; bh=ARYr/LKj+yZwEU4iRvbH7FzrNzmdYr/PkmH9b2I+f04=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=x3/YZumM25/8IonJStbBK+UZyMFk37oMRLu8/repVytNddbCg44ZZpPqxFQCRU+xN VN+oYHWtsLhF/PBcfza/FqayjV6rs1cYymurEF4lUMAvXPXiVKqXQGw3tsGrw3tavo 0Joeoa+swrjyd0ifZbpe2ZZS/vDl2JgvvklqWY/U= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730859AbgCaM03 (ORCPT ); Tue, 31 Mar 2020 08:26:29 -0400 Received: from mail.kernel.org ([198.145.29.99]:56352 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730343AbgCaM02 (ORCPT ); Tue, 31 Mar 2020 08:26:28 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F2E7420848; Tue, 31 Mar 2020 12:26:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585657588; bh=ARYr/LKj+yZwEU4iRvbH7FzrNzmdYr/PkmH9b2I+f04=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Xq3N5hZp0GIAPSlbTvfr9BXe+y4LG9Uv3UovNY6Yk0YIOKwgVfPY8EgPzaDoKW2wd vSVoDGymgwdCPsZ71SZRea/1NWtuKq69d3jLgndLZgXHbCs5wgttrZgiQhTEhFWfll uO8myYXyLDlkGXOuzt5Hxw9vtfHh2ORTVvvFJdpw= Date: Tue, 31 Mar 2020 14:12:28 +0200 From: Greg Kroah-Hartman To: Pablo Neira Ayuso Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, netfilter-devel@vger.kernel.org Subject: Re: [PATCH 5.5 138/170] netfilter: nft_fwd_netdev: allow to redirect to ifb via ingress Message-ID: <20200331121228.GB1617997@kroah.com> References: <20200331085423.990189598@linuxfoundation.org> <20200331085438.148415210@linuxfoundation.org> <20200331101603.wmsbhgmjc6vf4esk@salvia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200331101603.wmsbhgmjc6vf4esk@salvia> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 31, 2020 at 12:16:03PM +0200, Pablo Neira Ayuso wrote: > On Tue, Mar 31, 2020 at 10:59:12AM +0200, Greg Kroah-Hartman wrote: > > From: Pablo Neira Ayuso > > > > commit bcfabee1afd99484b6ba067361b8678e28bbc065 upstream. > > > > Set skb->tc_redirected to 1, otherwise the ifb driver drops the packet. > > Set skb->tc_from_ingress to 1 to reinject the packet back to the ingress > > path after leaving the ifb egress path. > > > > This patch inconditionally sets on these two skb fields that are > > meaningful to the ifb driver. The existing forward action is guaranteed > > to run from ingress path. > > > > Fixes: 39e6dea28adc ("netfilter: nf_tables: add forward expression to the netdev family") > > Signed-off-by: Pablo Neira Ayuso > > Signed-off-by: Greg Kroah-Hartman > > > > --- > > net/netfilter/nft_fwd_netdev.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > --- a/net/netfilter/nft_fwd_netdev.c > > +++ b/net/netfilter/nft_fwd_netdev.c > > @@ -28,6 +28,10 @@ static void nft_fwd_netdev_eval(const st > > struct nft_fwd_netdev *priv = nft_expr_priv(expr); > > int oif = regs->data[priv->sreg_dev]; > > > > + /* These are used by ifb only. */ > > + pkt->skb->tc_redirected = 1; > > + pkt->skb->tc_from_ingress = 1; > > This patch also requires: > > 2c64605b590e net: Fix CONFIG_NET_CLS_ACT=n and CONFIG_NFT_FWD_NETDEV={y, m} build > > Otherwise build breaks with CONFIG_NET_CLS_ACT=n. Thanks for the hint, will go do that now. greg k-h