From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B0D0C2D0F0 for ; Tue, 31 Mar 2020 12:59:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2104620658 for ; Tue, 31 Mar 2020 12:59:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="KxQalpqH" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730830AbgCaM7M (ORCPT ); Tue, 31 Mar 2020 08:59:12 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:40994 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730473AbgCaM7L (ORCPT ); Tue, 31 Mar 2020 08:59:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=mFwgAlR7Lk3HX7sPCyBzL0qhRjsF1JNGuPfhbeEkszU=; b=KxQalpqH3raFULxaqMR/cAt8sT dSV0sMsR3f0sYGvo/CKKbMKdbjR0jJ12Rej8KbjPfdFEmVcf29rfF3WcdkjBuCeoUbxbMF01q41HE NhQ7LowcBhtLm9ITFjlTqgZsZZjShX8kP/GEQPj5/z4FceDBdcbBptGmFPgyNe+qoZN8=; Received: from andrew by vps0.lunn.ch with local (Exim 4.93) (envelope-from ) id 1jJGU0-000D0f-KK; Tue, 31 Mar 2020 14:59:08 +0200 Date: Tue, 31 Mar 2020 14:59:08 +0200 From: Andrew Lunn To: Codrin.Ciubotariu@microchip.com Cc: f.fainelli@gmail.com, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net Subject: Re: [PATCH] net: mdio: of: Do not treat fixed-link as PHY Message-ID: <20200331125908.GB24486@lunn.ch> References: <20200330160136.23018-1-codrin.ciubotariu@microchip.com> <20200330163028.GE23477@lunn.ch> <9bbbe2ed-985b-49e7-cc16-8b6bae3e8e8e@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Thanks guys. I thought there might be other controllers that have the > PHY nodes inside the ethernet node. Hi Codrin There are some still using this deprecated feature. But macb is the only one doing this odd looping over child nodes. It is this looping which is breaking things, not the use of the deprecated feature itself. Andrew